[webkit-changes] cvs commit: WebCore/kwq KWQKHTMLPart.mm
Adele
adele at opensource.apple.com
Wed Jul 20 12:55:13 PDT 2005
adele 05/07/20 12:55:13
Modified: . ChangeLog
kwq KWQKHTMLPart.mm
Log:
Rolling fix for <rdar://problem/4046602> back in.
2005-03-11 David Harrison <harrison at apple.com>
Reviewed by Darin.
<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::advanceToNextMisspelling):
(KWQKHTMLPart::markMisspellings):
Nil check checker.
Revision Changes Path
1.4452 +15 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.4451
retrieving revision 1.4452
diff -u -r1.4451 -r1.4452
--- ChangeLog 20 Jul 2005 18:17:27 -0000 1.4451
+++ ChangeLog 20 Jul 2005 19:55:08 -0000 1.4452
@@ -1,5 +1,20 @@
2005-07-20 Adele Peterson <adele at apple.com>
+ Rolling fix for <rdar://problem/4046602> back in.
+
+ 2005-03-11 David Harrison <harrison at apple.com>
+
+ Reviewed by Darin.
+
+ <rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running
+
+ * kwq/KWQKHTMLPart.mm:
+ (KWQKHTMLPart::advanceToNextMisspelling):
+ (KWQKHTMLPart::markMisspellings):
+ Nil check checker.
+
+2005-07-20 Adele Peterson <adele at apple.com>
+
Reviewed by Darin.
- fixed <rdar://problem/4181058> 8C45: Safari repro crash with document.write (DOM::NodeImpl::dispatchEvent)
1.652 +8 -0 WebCore/kwq/KWQKHTMLPart.mm
Index: KWQKHTMLPart.mm
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQKHTMLPart.mm,v
retrieving revision 1.651
retrieving revision 1.652
diff -u -r1.651 -r1.652
--- KWQKHTMLPart.mm 18 Jul 2005 21:52:36 -0000 1.651
+++ KWQKHTMLPart.mm 20 Jul 2005 19:55:12 -0000 1.652
@@ -983,7 +983,11 @@
return QString(); // nothing to search in
}
+ // Get the spell checker if it is available
NSSpellChecker *checker = [NSSpellChecker sharedSpellChecker];
+ if (checker == nil)
+ return QString();
+
WordAwareIterator it(searchRange.get());
bool wrapped = false;
@@ -3995,7 +3999,11 @@
if (!editableNodeImpl->isContentEditable())
return;
+ // Get the spell checker if it is available
NSSpellChecker *checker = [NSSpellChecker sharedSpellChecker];
+ if (checker == nil)
+ return;
+
WordAwareIterator it(searchRange.get());
while (!it.atEnd()) { // we may be starting at the end of the doc, and already by atEnd
More information about the webkit-changes
mailing list