[webkit-changes] cvs commit: WebCore/layout-tests/fast/dom/Window window-special-properties-expected.txt

[Maciej]

mjs         05/07/19 21:04:54

  Modified:    .        ChangeLog
               khtml/html html_objectimpl.cpp
               layout-tests/fast/dom/Window
                        window-special-properties-expected.txt
  Log:
          Reviewed by Kevin.
  
  	- fixed some mistakes in my previous checkin
  
          * khtml/html/html_objectimpl.cpp:
          (DOM::HTMLAppletElementImpl::parseMappedAttribute): Take name attribute out
  	of the "do nothing" case (duh).
          * layout-tests/fast/dom/Window/window-special-properties-expected.txt: Update
  	for change to the text at the top.
  
  Revision  Changes    Path
  1.4449    +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4448
  retrieving revision 1.4449
  diff -u -r1.4448 -r1.4449
  --- ChangeLog	20 Jul 2005 02:35:26 -0000	1.4448
  +++ ChangeLog	20 Jul 2005 04:04:50 -0000	1.4449
  @@ -1,3 +1,15 @@
  +2005-07-19  Maciej Stachowiak  <mjs at apple.com>
  +
  +        Reviewed by Kevin.
  +
  +	- fixed some mistakes in my previous checkin
  +
  +        * khtml/html/html_objectimpl.cpp:
  +        (DOM::HTMLAppletElementImpl::parseMappedAttribute): Take name attribute out
  +	of the "do nothing" case (duh).
  +        * layout-tests/fast/dom/Window/window-special-properties-expected.txt: Update
  +	for change to the text at the top.
  +
   2005-07-18  Maciej Stachowiak  <mjs at apple.com>
   
           Reviewed by Darin.
  
  
  
  1.72      +0 -1      WebCore/khtml/html/html_objectimpl.cpp
  
  Index: html_objectimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_objectimpl.cpp,v
  retrieving revision 1.71
  retrieving revision 1.72
  diff -u -r1.71 -r1.72
  --- html_objectimpl.cpp	20 Jul 2005 02:35:31 -0000	1.71
  +++ html_objectimpl.cpp	20 Jul 2005 04:04:53 -0000	1.72
  @@ -99,7 +99,6 @@
           attr->name() == HTMLAttributes::code() ||
           attr->name() == HTMLAttributes::codebase() ||
           attr->name() == HTMLAttributes::mayscript() ||
  -        attr->name() == HTMLAttributes::name() ||
           attr->name() == HTMLAttributes::object()) {
           // Do nothing.
       } else if (attr->name() == HTMLAttributes::width()) {
  
  
  
  1.2       +2 -2      WebCore/layout-tests/fast/dom/Window/window-special-properties-expected.txt
  
  Index: window-special-properties-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/fast/dom/Window/window-special-properties-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- window-special-properties-expected.txt	20 Jul 2005 02:35:33 -0000	1.1
  +++ window-special-properties-expected.txt	20 Jul 2005 04:04:53 -0000	1.2
  @@ -1,6 +1,6 @@
   This test covers the various ways of accessing DOM elements through the window object by name, id or index, directly as properties of the window object. This lookup is supposed to include applet, embed, form, image and object by name, and all elements by id. It should give the element itself in the case of a single match, or an HTMLCollection in the case of multiple matches; except that when iframes are involved, it will give the window object for the first iframe match.
   
  -Our results match WinIE in all respects but one. We allow child frame names to take precedence over built-in and custom properties of the window object. This is the Mozilla behavior and is required to make some sites work because they use frame names that collide with built-in properties in Mozilla but not IE.
  +Our results match WinIE in all respects but one. We allow child frame names to take precedence over built-in and custom properties of the window object. This is the Mozilla behavior and is required to make some sites work because they use frame names that collide with built-in properties in Mozilla but not IE - specifically "toobar". See Radar 3870317.
   
   Results:
   
  @@ -65,4 +65,4 @@
   Conflicting image: single OTHER
   Conflicting image (custom property): single OTHER
   Conflicting iframe: single WINDOW
  -
  +\ No newline at end of file