[webkit-changes] cvs commit: WebCore/manual-tests textarea-after-stylesheet-link.html

[Geoffrey]

ggaren      05/07/19 19:04:43

  Modified:    .        ChangeLog
               khtml/html html_formimpl.cpp html_formimpl.h
  Added:       manual-tests textarea-after-stylesheet-link.html
  Log:
          -rolled in patch by Anders Carlsson <andersca at mac.com> for
          http://bugzilla.opendarwin.org/show_bug.cgi?id=3751
          REGRESSION: affects Blogger, GMail & Wikipedia: empty textarea's which should have content
  
          Reviewed by mjs.
  
          * khtml/html/html_formimpl.cpp:
          (DOM::HTMLTextAreaElementImpl::defaultValue):
          (DOM::HTMLTextAreaElementImpl::attach):
          * khtml/html/html_formimpl.h:
  
          Test cases added:
          * manual-tests/textarea-after-stylesheet-link.html: Added.
          Test is manual because the result doesn't show up in DumpRenderTree
  
  Revision  Changes    Path
  1.4447    +17 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4446
  retrieving revision 1.4447
  diff -u -r1.4446 -r1.4447
  --- ChangeLog	20 Jul 2005 01:17:24 -0000	1.4446
  +++ ChangeLog	20 Jul 2005 02:04:38 -0000	1.4447
  @@ -1,3 +1,20 @@
  +2005-07-19  Geoffrey Garen  <ggaren at apple.com>
  +
  +        -rolled in patch by Anders Carlsson <andersca at mac.com> for
  +        http://bugzilla.opendarwin.org/show_bug.cgi?id=3751
  +        REGRESSION: affects Blogger, GMail & Wikipedia: empty textarea's which should have content
  +        
  +        Reviewed by mjs.
  +
  +        * khtml/html/html_formimpl.cpp:
  +        (DOM::HTMLTextAreaElementImpl::defaultValue):
  +        (DOM::HTMLTextAreaElementImpl::attach):
  +        * khtml/html/html_formimpl.h:
  +
  +        Test cases added:
  +        * manual-tests/textarea-after-stylesheet-link.html: Added.
  +        Test is manual because the result doesn't show up in DumpRenderTree
  +
   2005-07-19  Justin Garcia  <justin.garcia at apple.com>
           
           Added a virtual deconstructor to fix gcc4 build warning
  
  
  
  1.175     +13 -6     WebCore/khtml/html/html_formimpl.cpp
  
  Index: html_formimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
  retrieving revision 1.174
  retrieving revision 1.175
  diff -u -r1.174 -r1.175
  --- html_formimpl.cpp	20 Jul 2005 00:45:49 -0000	1.174
  +++ html_formimpl.cpp	20 Jul 2005 02:04:42 -0000	1.175
  @@ -3520,13 +3520,13 @@
       for (n = firstChild(); n; n = n->nextSibling())
           if (n->isTextNode())
               val += static_cast<TextImpl*>(n)->data();
  +    
       if (val[0] == '\r' && val[1] == '\n') {
  -	val = val.copy();
  -	val.remove(0,2);
  -    }
  -    else if (val[0] == '\r' || val[0] == '\n') {
  -	val = val.copy();
  -	val.remove(0,1);
  +        val = val.copy();
  +        val.remove(0,2);
  +    } else if (val[0] == '\r' || val[0] == '\n') {
  +        val = val.copy();
  +        val.remove(0,1);
       }
   
       return val;
  @@ -3570,6 +3570,13 @@
       focus();
   }
   
  +void HTMLTextAreaElementImpl::attach()
  +{
  +    m_valueIsValid = true;
  +    HTMLGenericFormElementImpl::attach();
  +    updateValue();
  +}
  +
   void HTMLTextAreaElementImpl::detach()
   {
       HTMLGenericFormElementImpl::detach();
  
  
  
  1.79      +1 -0      WebCore/khtml/html/html_formimpl.h
  
  Index: html_formimpl.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.h,v
  retrieving revision 1.78
  retrieving revision 1.79
  diff -u -r1.78 -r1.79
  --- html_formimpl.h	18 Jul 2005 21:52:25 -0000	1.78
  +++ html_formimpl.h	20 Jul 2005 02:04:42 -0000	1.79
  @@ -752,6 +752,7 @@
       virtual void childrenChanged();
       virtual void parseMappedAttribute(MappedAttributeImpl *attr);
       virtual khtml::RenderObject *createRenderer(RenderArena *, khtml::RenderStyle *);
  +    virtual void attach();
       virtual void detach();
       virtual bool appendFormData(FormDataList&, bool);
       virtual void reset();
  
  
  
  1.1                  WebCore/manual-tests/textarea-after-stylesheet-link.html
  
  Index: textarea-after-stylesheet-link.html
  ===================================================================
  <html>
  <head>
  <script>
  if (window.layoutTestController) {
      window.layoutTestController.dumpAsText();
  }
  </script>
  <link rel="stylesheet" />
  </head>
  <body>
  <p>Tests: whether &lt;link rel="stylesheet"/&gt; disturbs the display of text in textareas</p>
  <p>Related bug: <a href = "http://bugzilla.opendarwin.org/show_bug.cgi?id=3751">3751: REGRESSION: affects Blogger, GMail & Wikipedia: empty textarea's which should have content</a></p>
  <p>Success: You will see "passed" inside the texarea below</p>
  <hr>
  <textarea>passed</textarea>
  </form>
  </body>
  </html>