[webkit-changes] cvs commit: WebKit/Plugins.subproj WebBaseNetscapePluginView.m

[Darin]

darin       05/07/19 12:48:45

  Modified:    .        ChangeLog
               Plugins.subproj WebBaseNetscapePluginView.m
  Log:
          Reviewed by Geoff Garen.
  
          - improve handling of plug-ins when the WebView or a superview is hidden with -[NSView setHidden]
  
          * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
          Add "hidden" to the list of reasons to clip out all plug-in drawing.
  
  Revision  Changes    Path
  1.3237    +9 -0      WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3236
  retrieving revision 1.3237
  diff -u -r1.3236 -r1.3237
  --- ChangeLog	19 Jul 2005 17:11:52 -0000	1.3236
  +++ ChangeLog	19 Jul 2005 19:48:42 -0000	1.3237
  @@ -1,3 +1,12 @@
  +2005-07-19  Darin Adler  <darin at apple.com>
  +
  +        Reviewed by Geoff Garen.
  +
  +        - improve handling of plug-ins when the WebView or a superview is hidden with -[NSView setHidden]
  +
  +        * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
  +        Add "hidden" to the list of reasons to clip out all plug-in drawing.
  +
   2005-07-18  John Sullivan  <sullivan at apple.com>
           
           Written by Trey Matteson  <trey at usa.net>
  
  
  
  1.137     +5 -1      WebKit/Plugins.subproj/WebBaseNetscapePluginView.m
  
  Index: WebBaseNetscapePluginView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/Plugins.subproj/WebBaseNetscapePluginView.m,v
  retrieving revision 1.136
  retrieving revision 1.137
  diff -u -r1.136 -r1.137
  --- WebBaseNetscapePluginView.m	11 Jul 2005 17:09:14 -0000	1.136
  +++ WebBaseNetscapePluginView.m	19 Jul 2005 19:48:45 -0000	1.137
  @@ -229,7 +229,11 @@
       // 4) we're inside of viewWillMoveToWindow: with a nil window. In this case, superviews may already have nil 
       // superviews and nil windows and results from convertRect:toView: are incorrect.
       NSWindow *realWindow = [self window];
  -    if (window.width <= 0 || window.height <= 0 || window.x < -100000 || realWindow == nil || [realWindow isMiniaturized] || [NSApp isHidden] || ![self superviewsHaveSuperviews]) {
  +    if (window.width <= 0 || window.height <= 0 || window.x < -100000
  +            || realWindow == nil || [realWindow isMiniaturized]
  +            || [NSApp isHidden]
  +            || ![self superviewsHaveSuperviews]
  +            || [self isHiddenOrHasHiddenAncestor]) {
           // The following code tries to give plug-ins the same size they will eventually have.
           // The specifiedWidth and specifiedHeight variables are used to predict the size that
           // WebCore will eventually resize us to.