[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp html_formimpl.h

Adele adele at opensource.apple.com
Tue Jul 12 15:15:24 PDT 2005


adele       05/07/12 15:15:24

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml/html Tag: Safari-2-0-branch html_formimpl.cpp
                        html_formimpl.h
  Log:
          Merged fix from TOT to Safari-2-0-branch
          <rdar://problem/4164969> A crash occurs when invoking assigned access key on a Button element (DOM::HTMLButtonElementImpl::click(bool) + 36)
  
      2005-06-17  Geoffrey Garen  <ggaren at apple.com>
  
  	Patch contributed by Anders Carlsson<andersca at mac.com>.
  
  	Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=3408
  
          Reviewed by Darin.
  
          Test cases added: None. Test requires manual interaction.
  	Manual test available at: http://bugzilla.opendarwin.org/attachment.cgi?id=2207
  
          * khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
          * khtml/html/html_formimpl.h: Ditto.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.4104.2.59 +19 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4104.2.58
  retrieving revision 1.4104.2.59
  diff -u -r1.4104.2.58 -r1.4104.2.59
  --- ChangeLog	12 Jul 2005 22:05:12 -0000	1.4104.2.58
  +++ ChangeLog	12 Jul 2005 22:15:17 -0000	1.4104.2.59
  @@ -1,6 +1,25 @@
   2005-07-12  Adele Peterson  <adele at apple.com>
   
           Merged fix from TOT to Safari-2-0-branch
  +        <rdar://problem/4164969> A crash occurs when invoking assigned access key on a Button element (DOM::HTMLButtonElementImpl::click(bool) + 36)
  +
  +    2005-06-17  Geoffrey Garen  <ggaren at apple.com>
  +
  +	Patch contributed by Anders Carlsson<andersca at mac.com>.
  +
  +	Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=3408	
  +
  +        Reviewed by Darin.
  +
  +        Test cases added: None. Test requires manual interaction.
  +	Manual test available at: http://bugzilla.opendarwin.org/attachment.cgi?id=2207
  +
  +        * khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click. 
  +        * khtml/html/html_formimpl.h: Ditto.
  +
  +2005-07-12  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
           <rdar://problem/4164967>
   
       2005-06-17  Adele Peterson  <adele at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.156.6.3 +0 -13     WebCore/khtml/html/html_formimpl.cpp
  
  Index: html_formimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
  retrieving revision 1.156.6.2
  retrieving revision 1.156.6.3
  diff -u -r1.156.6.2 -r1.156.6.3
  --- html_formimpl.cpp	12 Jul 2005 17:52:31 -0000	1.156.6.2
  +++ html_formimpl.cpp	12 Jul 2005 22:15:23 -0000	1.156.6.3
  @@ -1195,19 +1195,6 @@
       return true;
   }
   
  -void HTMLButtonElementImpl::click(bool sendMouseEvents)
  -{
  -#if APPLE_CHANGES
  -    QWidget *widget;
  -    if (renderer() && (widget = static_cast<RenderWidget *>(renderer())->widget())) {
  -        // using this method gives us nice Cocoa user interface feedback
  -        static_cast<QButton *>(widget)->click(sendMouseEvents);
  -    }
  -    else
  -#endif
  -        HTMLGenericFormElementImpl::click(sendMouseEvents);
  -}
  -
   void HTMLButtonElementImpl::accessKeyAction(bool sendToAnyElement)
   {   
       // send the mouse button events iff the
  
  
  
  1.67.6.2  +0 -1      WebCore/khtml/html/html_formimpl.h
  
  Index: html_formimpl.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.h,v
  retrieving revision 1.67.6.1
  retrieving revision 1.67.6.2
  diff -u -r1.67.6.1 -r1.67.6.2
  --- html_formimpl.h	12 Jul 2005 00:45:45 -0000	1.67.6.1
  +++ html_formimpl.h	12 Jul 2005 22:15:24 -0000	1.67.6.2
  @@ -234,7 +234,6 @@
       virtual bool isActivatedSubmit() const;
       virtual void setActivatedSubmit(bool flag);
   
  -    virtual void click(bool sendMouseEvents);
       virtual void accessKeyAction(bool sendToAnyElement);
       void blur();
       void focus();
  
  
  



More information about the webkit-changes mailing list