[webkit-changes] cvs commit: WebKit/Panels.subproj WebAuthenticationPanel.m

[Adele]

adele       05/07/12 13:11:13

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               Panels.subproj Tag: Safari-1-3-branch
                        WebAuthenticationPanel.m
  Log:
          Merged fix from TOT to Safari-1-3-branch
          <rdar://problem/4164950> Safari crashes if Esc key is held down during series of authentication sheets
  
      2005-05-13  John Sullivan  <sullivan at apple.com>
  
          Reviewed by Kevin.
  
          - fixed <rdar://problem/4093306> Safari crashes if Esc key is held down during series
          of authentication sheets
  
          * Panels.subproj/WebAuthenticationPanel.m:
          (-[WebAuthenticationPanel cancel:]):
          retain and autorelease self. This is a workaround for an AppKit key-handling issue, which I wrote up as:
          <rdar://problem/4118422> Key-down events can be sent to a closed window if a key is kept pressed down
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.3120.2.7 +17 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3120.2.6
  retrieving revision 1.3120.2.7
  diff -u -r1.3120.2.6 -r1.3120.2.7
  --- ChangeLog	12 Jul 2005 20:04:56 -0000	1.3120.2.6
  +++ ChangeLog	12 Jul 2005 20:11:08 -0000	1.3120.2.7
  @@ -1,6 +1,23 @@
   2005-07-12  Adele Peterson  <adele at apple.com>
   
           Merged fix from TOT to Safari-1-3-branch
  +        <rdar://problem/4164950> Safari crashes if Esc key is held down during series of authentication sheets
  +
  +    2005-05-13  John Sullivan  <sullivan at apple.com>
  +
  +        Reviewed by Kevin.
  +        
  +        - fixed <rdar://problem/4093306> Safari crashes if Esc key is held down during series 
  +        of authentication sheets
  +
  +        * Panels.subproj/WebAuthenticationPanel.m:
  +        (-[WebAuthenticationPanel cancel:]):
  +        retain and autorelease self. This is a workaround for an AppKit key-handling issue, which I wrote up as:
  +        <rdar://problem/4118422> Key-down events can be sent to a closed window if a key is kept pressed down
  +
  +2005-07-12  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-1-3-branch
           <rdar://problem/4164949> REGRESSION (Tiger): progressively loaded background images "scroll down" instead of just appearing
   
       2005-04-18  Darin Adler  <darin at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.30.6.1  +3 -0      WebKit/Panels.subproj/WebAuthenticationPanel.m
  
  Index: WebAuthenticationPanel.m
  ===================================================================
  RCS file: /cvs/root/WebKit/Panels.subproj/WebAuthenticationPanel.m,v
  retrieving revision 1.30
  retrieving revision 1.30.6.1
  diff -u -r1.30 -r1.30.6.1
  --- WebAuthenticationPanel.m	14 Dec 2004 00:15:02 -0000	1.30
  +++ WebAuthenticationPanel.m	12 Jul 2005 20:11:12 -0000	1.30.6.1
  @@ -52,6 +52,9 @@
       // crash later when finishing button hit tracking.  So we make
       // sure it lives on a bit longer.
       [[panel retain] autorelease];
  +    
  +    // This is required as a workaround for AppKit issue 4118422
  +    [[self retain] autorelease];
   
       [panel close];
       if (usingSheet) {