[webkit-changes] cvs commit: WebCore/khtml/rendering render_form.cpp

[Adele]

adele       05/07/12 10:37:52

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               khtml/rendering Tag: Safari-1-3-branch render_form.cpp
  Log:
          Merged fix from TOT to Safari-1-3-branch
          <rdar://problem/4164939> Selects wrapped by Span or Label elements do not resize when options are added via javascript
  
      2005-06-17  Vicki Murley  <vicki at apple.com>
  
          Reviewed by Maciej.
  
          Test cases added: None, since this test requires manual interaction.
  
  	- fixed <rdar://problem/4086793> Selects wrapped by Span or Label elements
  	do not resize when options are added via javascript
  
  	* khtml/rendering/render_form.cpp:
          (RenderSelect::layout): Remove call setting setNeedsLayout to true. setNeedsLayout
  	is already true at this point, and this additional call has the negative effect of
  	marking m_normalChildNeedsLayout on the element's parent, which keeps layout from
  	propagating all the way up to the root later on.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.4108.4.18 +21 -1     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4108.4.17
  retrieving revision 1.4108.4.18
  diff -u -r1.4108.4.17 -r1.4108.4.18
  --- ChangeLog	12 Jul 2005 16:57:44 -0000	1.4108.4.17
  +++ ChangeLog	12 Jul 2005 17:37:46 -0000	1.4108.4.18
  @@ -1,6 +1,26 @@
   2005-07-12  Adele Peterson  <adele at apple.com>
   
  -        Merged fix from TOT to Safari-2-0-branch
  +        Merged fix from TOT to Safari-1-3-branch
  +        <rdar://problem/4164939> Selects wrapped by Span or Label elements do not resize when options are added via javascript
  +
  +    2005-06-17  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Maciej. 
  +
  +        Test cases added: None, since this test requires manual interaction.
  +
  +	- fixed <rdar://problem/4086793> Selects wrapped by Span or Label elements 
  +	do not resize when options are added via javascript
  +        
  +	* khtml/rendering/render_form.cpp:
  +        (RenderSelect::layout): Remove call setting setNeedsLayout to true. setNeedsLayout
  +	is already true at this point, and this additional call has the negative effect of 
  +	marking m_normalChildNeedsLayout on the element's parent, which keeps layout from 
  +	propagating all the way up to the root later on.
  +
  +2005-07-12  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-1-3-branch
           <rdar://problem/4164931> crash in DOM::ElementImpl::setAttribute at www.nitto-kohki.co.jp
   
       2005-05-11  Adele Peterson  <adele at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.102.6.1 +0 -2      WebCore/khtml/rendering/render_form.cpp
  
  Index: render_form.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_form.cpp,v
  retrieving revision 1.102
  retrieving revision 1.102.6.1
  diff -u -r1.102 -r1.102.6.1
  --- render_form.cpp	19 Mar 2005 00:34:07 -0000	1.102
  +++ render_form.cpp	12 Jul 2005 17:37:51 -0000	1.102.6.1
  @@ -1275,8 +1275,6 @@
           setIntrinsicHeight( s.height() );
       }
   
  -    /// uuh, ignore the following line..
  -    setNeedsLayout(true);
       RenderFormElement::layout();
   
       // and now disable the widget in case there is no <option> given