[webkit-changes] cvs commit: WebKit/Plugins.subproj WebBaseNetscapePluginView.m

[Kevin]

kdecker     05/07/11 09:57:39

  Modified:    .        ChangeLog
               Plugins.subproj WebBaseNetscapePluginView.m
  Log:
          Reviewed by cblu and mjs.
  
  	Fixed: <rdar://problem/4099552> REGRESSION: Safari 1.3 Netscape API NPN_PostURL[Notify] no longer allows manual headers
  
  	Most plugins (flash) send 2 CRFL's between the header and body of their POST requests, while the adboe plugin sends two LF's. This caused us to send custom headers as part of the actual POST data itself, and correspondently, would skew Content-Length.
  
          * Plugins.subproj/WebBaseNetscapePluginView.m:
          (-[NSData _web_locationAfterFirstBlankLine]): Look for two LF's as well
  
  Revision  Changes    Path
  1.3219    +11 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3218
  retrieving revision 1.3219
  diff -u -r1.3218 -r1.3219
  --- ChangeLog	10 Jul 2005 00:45:50 -0000	1.3218
  +++ ChangeLog	11 Jul 2005 16:57:37 -0000	1.3219
  @@ -1,3 +1,14 @@
  +2005-07-11  Kevin Decker  <kdecker at apple.com>
  +
  +        Reviewed by cblu and mjs.
  +
  +	Fixed: <rdar://problem/4099552> REGRESSION: Safari 1.3 Netscape API NPN_PostURL[Notify] no longer allows manual headers
  +	
  +	Most plugins (flash) send 2 CRFL's between the header and body of their POST requests, while the adboe plugin sends two LF's. This caused us to send custom headers as part of the actual POST data itself, and correspondently, would skew Content-Length.
  +
  +        * Plugins.subproj/WebBaseNetscapePluginView.m:
  +        (-[NSData _web_locationAfterFirstBlankLine]): Look for two LF's as well
  +
   2005-07-09  Maciej Stachowiak  <mjs at apple.com>
   
           - back out my revent page cache changes, turns out they cause a
  
  
  
  1.134     +8 -1      WebKit/Plugins.subproj/WebBaseNetscapePluginView.m
  
  Index: WebBaseNetscapePluginView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/Plugins.subproj/WebBaseNetscapePluginView.m,v
  retrieving revision 1.133
  retrieving revision 1.134
  diff -u -r1.133 -r1.134
  --- WebBaseNetscapePluginView.m	6 Jun 2005 14:53:46 -0000	1.133
  +++ WebBaseNetscapePluginView.m	11 Jul 2005 16:57:39 -0000	1.134
  @@ -1798,7 +1798,7 @@
       return [self length] > 0 && ((const char *)[self bytes])[0] == '\n';
   }
   
  -// Returns the position after 2 CRLF's or 1 CRLF if it is the first line.
  +
   - (unsigned)_web_locationAfterFirstBlankLine
   {
       const char *bytes = (const char *)[self bytes];
  @@ -1806,6 +1806,13 @@
       
       unsigned i;
       for (i = 0; i < length - 4; i++) {
  +        
  +        //most plugins (Flash) send 2 CRFL's between the header and body of their POST requests, while the adboe plugin sends two LF's.
  +        if (bytes[i] == '\n' && bytes[i+1] == '\n') {
  +            return i+2;
  +        }
  +        
  +        // Returns the position after 2 CRLF's or 1 CRLF if it is the first line.
           if (bytes[i] == '\r' && bytes[i+1] == '\n') {
               i += 2;
               if (i == 2) {