[webkit-changes] cvs commit: JavaScriptCore/kjs collector.cpp

[Maciej]

mjs         05/07/09 17:38:11

  Modified:    .        ChangeLog
               kjs      collector.cpp
  Log:
          - backing out my earlier collector change, it causes a performance regression in TOT
  
          * kjs/collector.cpp:
          (KJS::Collector::allocate):
  
  Revision  Changes    Path
  1.743     +7 -0      JavaScriptCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
  retrieving revision 1.742
  retrieving revision 1.743
  diff -u -r1.742 -r1.743
  --- ChangeLog	9 Jul 2005 06:59:53 -0000	1.742
  +++ ChangeLog	10 Jul 2005 00:38:10 -0000	1.743
  @@ -1,3 +1,10 @@
  +2005-07-09  Maciej Stachowiak  <mjs at apple.com>
  +
  +        - backing out my earlier collector change, it causes a performance regression in TOT
  +
  +        * kjs/collector.cpp:
  +        (KJS::Collector::allocate):
  +
   2005-07-08  Eric Seidel  <eseidel at apple.com>
   
           Reviewed by mjs/hyatt (only in concept).
  
  
  
  1.38      +1 -4      JavaScriptCore/kjs/collector.cpp
  
  Index: collector.cpp
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/kjs/collector.cpp,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -r1.37 -r1.38
  --- collector.cpp	9 Jul 2005 03:23:13 -0000	1.37
  +++ collector.cpp	10 Jul 2005 00:38:11 -0000	1.38
  @@ -93,10 +93,7 @@
   
     // collect if needed
     int numLiveObjects = heap.numLiveObjects;
  -  int liveAtLastCollect = heap.numLiveObjectsAtLastCollect;
  -  int delta = numLiveObjects - liveAtLastCollect;
  -  if ((delta >= 1000 && delta >= liveAtLastCollect) ||
  -      numLiveObjects == KJS_MEM_LIMIT - 1) {
  +  if (numLiveObjects - heap.numLiveObjectsAtLastCollect >= ALLOCATIONS_PER_COLLECTION) {
       collect();
       numLiveObjects = heap.numLiveObjects;
     }