[webkit-changes] cvs commit: WebKit ChangeLog
Geoffrey
ggaren at opensource.apple.com
Fri Jul 8 17:53:30 PDT 2005
ggaren 05/07/08 17:53:30
Modified: . ChangeLog
. ChangeLog
Added: layout-tests/fast/text/international
bidi-fallback-font-weight-expected.txt
bidi-fallback-font-weight.html
Log:
WebCore:
Rolled in layout test for fix to
http://bugzilla.opendarwin.org/show_bug.cgi?id=3818
Fallback font doesn't have requested weight in ATSUI-rendered text
Reviewed by mjs.
Test cases added:
* layout-tests/fast/text/international/bidi-fallback-font-weight-expected.txt: Added.
* layout-tests/fast/text/international/bidi-fallback-font-weight.html: Added.
WebKit:
Rolled in patch by opendarwin.org at mitzpettel.com
-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3818
Fallback font doesn't have requested weight in ATSUI-rendered text
(See WebCore Changelog for layout test)
Reviewed by mjs.
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer _createATSUTextLayoutForRun:style:]):
Revision Changes Path
1.4394 +12 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.4393
retrieving revision 1.4394
diff -u -r1.4393 -r1.4394
--- ChangeLog 9 Jul 2005 00:30:54 -0000 1.4393
+++ ChangeLog 9 Jul 2005 00:53:23 -0000 1.4394
@@ -1,3 +1,15 @@
+2005-07-08 Geoffrey Garen <ggaren at apple.com>
+
+ Rolled in layout test for fix to
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=3818
+ Fallback font doesn't have requested weight in ATSUI-rendered text
+
+ Reviewed by mjs.
+
+ Test cases added:
+ * layout-tests/fast/text/international/bidi-fallback-font-weight-expected.txt: Added.
+ * layout-tests/fast/text/international/bidi-fallback-font-weight.html: Added.
+
2005-07-08 Beth Dakin <bdakin at apple.com>
Reviewed by John.
1.1 WebCore/layout-tests/fast/text/international/bidi-fallback-font-weight-expected.txt
Index: bidi-fallback-font-weight-expected.txt
===================================================================
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x202
RenderBlock {HTML} at (0,0) size 800x202
RenderBody {BODY} at (8,16) size 784x170
RenderBlock {P} at (0,0) size 784x36
RenderText {TEXT} at (0,0) size 784x36
text run at (0,0) width 311: "In each of the following lines, the Hebrew letters "
text run at (311,0) width 34: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
text run at (345,0) width 439: " in the end should be in boldface (compare with the same letters in the"
text run at (0,18) width 443: "middle of the line). Disregard the third line if you don\x{2019}t have Raanana."
RenderBlock {P} at (0,52) size 784x18
RenderText {TEXT} at (0,0) size 82x18
text run at (0,0) width 43: "abcd "
text run at (43,0) width 34: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
text run at (77,0) width 5: " "
RenderInline {B} at (0,0) size 81x18
RenderText {TEXT} at (82,0) size 81x18
text run at (82,0) width 45: "abcd "
text run at (127,0) width 36: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
RenderText {TEXT} at (0,0) size 0x0
RenderBlock {P} at (0,86) size 784x18
RenderText {TEXT} at (0,0) size 94x18
text run at (0,0) width 50: "abcd "
text run at (50,0) width 34: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
text run at (84,0) width 10: " "
RenderInline {B} at (0,0) size 86x18
RenderText {TEXT} at (94,0) size 86x18
text run at (94,0) width 50: "abcd "
text run at (144,0) width 36: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
RenderText {TEXT} at (0,0) size 0x0
RenderBlock {P} at (0,120) size 784x16
RenderText {TEXT} at (0,0) size 74x16
text run at (0,0) width 42: "abcd "
text run at (42,0) width 28: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
text run at (70,0) width 4: " "
RenderInline {B} at (0,0) size 73x16
RenderText {TEXT} at (74,0) size 73x16
text run at (74,0) width 44: "abcd "
text run at (118,0) width 29: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
RenderText {TEXT} at (0,0) size 0x0
RenderBlock {P} at (0,152) size 784x18
RenderText {TEXT} at (0,0) size 77x18
text run at (0,0) width 39: "abcd "
text run at (39,0) width 34: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
text run at (73,0) width 4: " "
RenderInline {B} at (0,0) size 78x18
RenderText {TEXT} at (77,0) size 78x18
text run at (77,0) width 42: "abcd "
text run at (119,0) width 36: "\x{5D0}\x{5D1}\x{5D2}\x{5D3}"
RenderText {TEXT} at (0,0) size 0x0
1.1 WebCore/layout-tests/fast/text/international/bidi-fallback-font-weight.html
Index: bidi-fallback-font-weight.html
===================================================================
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>ATSUI fallback font</title>
</head>
<body>
<p>
In each of the following lines, the Hebrew
letters אבגד in the end should be in boldface
(compare with the same letters in the middle of the line).
Disregard the third line if you don’t have Raanana.
</p>
<!-- Lucida Grande exists and includes Hebrew; no fallback necessary -->
<p style="font-family:'Lucida Grande';">
abcd אבגד
<b>abcd אבגד</b>
</p>
<!-- Courier exists but doesn't include Hebrew; WebKit falls back to
Helvetica and Helvetica Bold for Hebrew, but then ATSUI falls back to
Lucida Grande (not bold) -->
<p style="font-family:'Courier';">
abcd אבגד
<b>abcd אבגד</b>
</p>
<!-- Raanana exists but doesn't include Roman; WebKit falls back to
Helvetica and Helvetica Bold for Roman -->
<p style="font-family:'Raanana';">
abcd אבגד
<b>abcd אבגד</b>
</p>
<!-- noSuchFamilyForSure doesn't exist; WebKit falls back to Helvetica
and Helvetica Bold for both Roman and Hebrew, but then ATSUI falls back to
Lucida Grande (not bold) for Hebrew -->
<p style="font-family:'noSuchFamilyForSure';">
abcd אבגד
<b>abcd אבגד</b>
</p>
</body>
1.3214 +2 -0 WebKit/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebKit/ChangeLog,v
retrieving revision 1.3213
retrieving revision 1.3214
diff -u -r1.3213 -r1.3214
--- ChangeLog 9 Jul 2005 00:48:22 -0000 1.3213
+++ ChangeLog 9 Jul 2005 00:53:26 -0000 1.3214
@@ -5,6 +5,8 @@
-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3818
Fallback font doesn't have requested weight in ATSUI-rendered text
+ (See WebCore Changelog for layout test)
+
Reviewed by mjs.
* WebCoreSupport.subproj/WebTextRenderer.m:
More information about the webkit-changes
mailing list