[webkit-changes] cvs commit: WebCore/khtml/xml dom_docimpl.cpp
Adele
adele at opensource.apple.com
Thu Jul 7 17:20:02 PDT 2005
adele 05/07/07 17:20:02
Modified: . ChangeLog
khtml/xml dom_docimpl.cpp
Log:
change by Maciej, reviewed by me.
fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)
No test cases added. There are some edge cases in which removeAllDisconnectedNodeEventListeners can get
called twice for the same document, and this can cause some nodes to unnecessarily remain in the
m_disconnectedNodesWithEventListeners list. This fix just clears the m_disconnectedNodesWithEventListeners
list after removing all event listeners for the disconnected nodes.
* khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):
Revision Changes Path
1.4388 +13 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.4387
retrieving revision 1.4388
diff -u -r1.4387 -r1.4388
--- ChangeLog 7 Jul 2005 17:06:46 -0000 1.4387
+++ ChangeLog 8 Jul 2005 00:19:58 -0000 1.4388
@@ -1,3 +1,16 @@
+2005-07-07 Adele Peterson <adele at apple.com>
+
+ change by Maciej, reviewed by me.
+
+ fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)
+
+ No test cases added. There are some edge cases in which removeAllDisconnectedNodeEventListeners can get
+ called twice for the same document, and this can cause some nodes to unnecessarily remain in the
+ m_disconnectedNodesWithEventListeners list. This fix just clears the m_disconnectedNodesWithEventListeners
+ list after removing all event listeners for the disconnected nodes.
+
+ * khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):
+
2005-07-07 Geoffrey Garen <ggaren at apple.com>
Reviewed by sullivan.
1.232 +1 -0 WebCore/khtml/xml/dom_docimpl.cpp
Index: dom_docimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/xml/dom_docimpl.cpp,v
retrieving revision 1.231
retrieving revision 1.232
diff -u -r1.231 -r1.232
--- dom_docimpl.cpp 3 Jul 2005 10:05:08 -0000 1.231
+++ dom_docimpl.cpp 8 Jul 2005 00:20:01 -0000 1.232
@@ -1328,6 +1328,7 @@
++iter) {
iter.current()->removeAllEventListeners();
}
+ m_disconnectedNodesWithEventListeners.clear();
}
#if APPLE_CHANGES
More information about the webkit-changes
mailing list