[webkit-changes] cvs commit: WebCore/khtml/ecma kjs_window.cpp

[Adele]

adele       05/07/01 18:39:55

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml/ecma Tag: Safari-2-0-branch kjs_window.cpp
  Log:
          Merged fix from TOT to Safari-2-0-branch
          <rdar://problem/4164976> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  
      2005-06-13  Vicki Murley  <vicki at apple.com>
  
          Reviewed by Darin.
  
          No test cases added since the steps to reproduce require use of showModalDialog.
  
          - fix for <rdar://problem/4145910> parameters not working in showModalDialog
          test page (dialogWidth, dialogHeight, etc.)
  
          * khtml/ecma/kjs_window.cpp:
          (KJS::parseFeatures): add a check for colon character in the feature string
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.4104.2.42 +17 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4104.2.41
  retrieving revision 1.4104.2.42
  diff -u -r1.4104.2.41 -r1.4104.2.42
  --- ChangeLog	2 Jul 2005 01:32:47 -0000	1.4104.2.41
  +++ ChangeLog	2 Jul 2005 01:39:49 -0000	1.4104.2.42
  @@ -1,6 +1,23 @@
   2005-07-01  Adele Peterson  <adele at apple.com>
   
           Merged fix from TOT to Safari-2-0-branch
  +        <rdar://problem/4164976> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  +
  +    2005-06-13  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Darin.
  +
  +        No test cases added since the steps to reproduce require use of showModalDialog.
  +
  +        - fix for <rdar://problem/4145910> parameters not working in showModalDialog 
  +        test page (dialogWidth, dialogHeight, etc.)
  +
  +        * khtml/ecma/kjs_window.cpp:
  +        (KJS::parseFeatures): add a check for colon character in the feature string
  +
  +2005-07-01  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
           <rdar://problem/4164982> add IE JavaScript extension window.showModalDialog
   
       2005-06-01  Darin Adler  <darin at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.146.8.5 +5 -0      WebCore/khtml/ecma/kjs_window.cpp
  
  Index: kjs_window.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_window.cpp,v
  retrieving revision 1.146.8.4
  retrieving revision 1.146.8.5
  diff -u -r1.146.8.4 -r1.146.8.5
  --- kjs_window.cpp	2 Jul 2005 01:32:57 -0000	1.146.8.4
  +++ kjs_window.cpp	2 Jul 2005 01:39:55 -0000	1.146.8.5
  @@ -501,6 +501,11 @@
       for (QStringList::ConstIterator it = features.begin(); it != end; ++it) {
           QString s = *it;
           int pos = s.find('=');
  +        int colonPos = s.find(':');
  +        if (pos >= 0 && colonPos >= 0)
  +            continue; // ignore any strings that have both = and :
  +        if (pos < 0)
  +            pos = colonPos;
           if (pos < 0) {
               // null string for value means key without value
               map.insert(s.stripWhiteSpace().lower(), QString());