[webkit-changes] cvs commit: JavaScriptCore/kjs nodes.cpp
Geoffrey
ggaren at opensource.apple.com
Fri Jul 1 10:19:20 PDT 2005
ggaren 05/07/01 10:19:20
Modified: . ChangeLog
kjs nodes.cpp
Log:
-fixed <rdar://problem/4168161> JavaScript fails to throw an exception
for invalid function calls
Reviewed by sullivan.
Relevant mozilla test: ecma_3/Exceptions/regress-95101.js
* kjs/nodes.cpp:
(FunctionCallNode::evaluate): evaluate now checks for an exception
after resolving a function name (in case the function is undefined)
Revision Changes Path
1.732 +13 -0 JavaScriptCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
retrieving revision 1.731
retrieving revision 1.732
diff -u -r1.731 -r1.732
--- ChangeLog 1 Jul 2005 09:55:01 -0000 1.731
+++ ChangeLog 1 Jul 2005 17:19:18 -0000 1.732
@@ -1,3 +1,16 @@
+2005-07-01 Geoffrey Garen <ggaren at apple.com>
+
+ -fixed <rdar://problem/4168161> JavaScript fails to throw an exception
+ for invalid function calls
+
+ Reviewed by sullivan.
+
+ Relevant mozilla test: ecma_3/Exceptions/regress-95101.js
+
+ * kjs/nodes.cpp:
+ (FunctionCallNode::evaluate): evaluate now checks for an exception
+ after resolving a function name (in case the function is undefined)
+
2005-07-01 Eric Seidel <eseidel at apple.com>
Reviewed by darin.
1.63 +1 -1 JavaScriptCore/kjs/nodes.cpp
Index: nodes.cpp
===================================================================
RCS file: /cvs/root/JavaScriptCore/kjs/nodes.cpp,v
retrieving revision 1.62
retrieving revision 1.63
diff -u -r1.62 -r1.63
--- nodes.cpp 1 Jul 2005 00:45:50 -0000 1.62
+++ nodes.cpp 1 Jul 2005 17:19:19 -0000 1.63
@@ -720,10 +720,10 @@
KJS_CHECKEXCEPTIONVALUE
List argList = args->evaluateList(exec);
-
KJS_CHECKEXCEPTIONVALUE
Value v = ref.getValue(exec);
+ KJS_CHECKEXCEPTIONVALUE
if (v.type() != ObjectType) {
return throwError(exec, TypeError, "Value %s (result of expression %s) is not object.", v, expr);
More information about the webkit-changes
mailing list