[webkit-changes] cvs commit: WebCore/khtml/html html_miscimpl.cpp html_miscimpl.h

[Eric]

eseidel     05/12/29 21:40:07

  Modified:    .        ChangeLog
               khtml/html html_miscimpl.cpp html_miscimpl.h
  Log:
  Bug #: 6295
  Submitted by: eseidel
  Reviewed by: mjs
          Close leak in CollectionInfo due to HashMap migration
          http://bugzilla.opendarwin.org/show_bug.cgi?id=6295
  
          * khtml/html/html_miscimpl.cpp:
          (DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
          * khtml/html/html_miscimpl.h:
  
  Revision  Changes    Path
  1.62      +11 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -r1.61 -r1.62
  --- ChangeLog	30 Dec 2005 05:33:16 -0000	1.61
  +++ ChangeLog	30 Dec 2005 05:40:06 -0000	1.62
  @@ -1,3 +1,14 @@
  +2005-12-29  Eric Seidel  <eseidel at apple.com>
  +
  +        Reviewed by mjs.
  +
  +        Close leak in CollectionInfo due to HashMap migration
  +        http://bugzilla.opendarwin.org/show_bug.cgi?id=6295
  +
  +        * khtml/html/html_miscimpl.cpp:
  +        (DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
  +        * khtml/html/html_miscimpl.h:
  +
   2005-12-29  Maciej Stachowiak  <mjs at apple.com>
   
           Reviewed by Eric.
  
  
  
  1.43      +6 -0      WebCore/khtml/html/html_miscimpl.cpp
  
  Index: html_miscimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_miscimpl.cpp,v
  retrieving revision 1.42
  retrieving revision 1.43
  diff -u -r1.42 -r1.43
  --- html_miscimpl.cpp	30 Dec 2005 04:11:49 -0000	1.42
  +++ html_miscimpl.cpp	30 Dec 2005 05:40:07 -0000	1.43
  @@ -98,6 +98,12 @@
       reset();
   }
   
  +HTMLCollectionImpl::CollectionInfo::~CollectionInfo()
  +{
  +    deleteAllValues(idCache);
  +    deleteAllValues(nameCache);
  +}
  +
   void HTMLCollectionImpl::CollectionInfo::reset()
   {
       current = 0;
  
  
  
  1.26      +1 -0      WebCore/khtml/html/html_miscimpl.h
  
  Index: html_miscimpl.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_miscimpl.h,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- html_miscimpl.h	30 Dec 2005 03:33:54 -0000	1.25
  +++ html_miscimpl.h	30 Dec 2005 05:40:07 -0000	1.26
  @@ -105,6 +105,7 @@
   
       struct CollectionInfo {
           CollectionInfo();
  +        ~CollectionInfo();
           void reset();
           unsigned int version;
           NodeImpl *current;