[webkit-changes] cvs commit: JavaScriptCore/kjs number_object.cpp

[Geoffrey]

ggaren      05/12/29 03:51:05

  Modified:    .        ChangeLog
               kjs      number_object.cpp
  Log:
          Patch by Maks Orlovich, reviewed and landed by me.
  
          - http://bugzilla.opendarwin.org/show_bug.cgi?id=6267
          Fix Number.prototype.toFixed/toExponential(undefined)
  
          * kjs/number_object.cpp:
          (NumberProtoFunc::callAsFunction):
  
  Revision  Changes    Path
  1.942     +11 -1     JavaScriptCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
  retrieving revision 1.941
  retrieving revision 1.942
  diff -u -r1.941 -r1.942
  --- ChangeLog	29 Dec 2005 11:45:31 -0000	1.941
  +++ ChangeLog	29 Dec 2005 11:51:03 -0000	1.942
  @@ -1,8 +1,18 @@
   2005-12-29  Geoffrey Garen  <ggaren at apple.com>
   
  +        Patch by Maks Orlovich, reviewed and landed by me.
  +
  +        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6267
  +        Fix Number.prototype.toFixed/toExponential(undefined)
  +
  +        * kjs/number_object.cpp:
  +        (NumberProtoFunc::callAsFunction):
  +
  +2005-12-29  Geoffrey Garen  <ggaren at apple.com>
  +
           Patch by Maks Orlovich, Reviewed and landed by me.
   
  -        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6266
  +        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6266
           Minor object naming updates (to match Mozilla, KJS)
   
           * kjs/number_object.cpp:
  
  
  
  1.28      +3 -1      JavaScriptCore/kjs/number_object.cpp
  
  Index: number_object.cpp
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/kjs/number_object.cpp,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- number_object.cpp	29 Dec 2005 11:45:32 -0000	1.27
  +++ number_object.cpp	29 Dec 2005 11:51:04 -0000	1.28
  @@ -160,6 +160,8 @@
     {
         JSValue *fractionDigits = args[0];
         double df = fractionDigits->toInteger(exec);
  +      if (fractionDigits->isUndefined())
  +            df = 0;
         if (!(df >= 0 && df <= 20)) // true for NaN
             return throwError(exec, RangeError, "toFixed() digits argument must be between 0 and 20");
         int f = (int)df;
  @@ -205,7 +207,7 @@
         
         JSValue *fractionDigits = args[0];
         double df = fractionDigits->toInteger(exec);
  -      if (!(df >= 0 && df <= 20)) // true for NaN
  +      if (!fractionDigits->isUndefined() && !(df >= 0 && df <= 20)) // true for NaN
             return throwError(exec, RangeError, "toExponential() argument must between 0 and 20");
         int f = (int)df;