[webkit-changes] cvs commit: LayoutTests/fast/js array-every-expected.txt array-every.html array-foreach-expected.txt array-foreach.html

Anders andersca at opensource.apple.com
Tue Dec 27 12:06:41 PST 2005


andersca    05/12/27 12:06:41

  Modified:    .        ChangeLog
               fast/js  array-every-expected.txt array-every.html
                        array-foreach-expected.txt array-foreach.html
  Log:
  2005-12-27  Anders Carlsson  <andersca at mac.com>
  
          Reviewed by Darin.
  
          - Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6250
          Implement Array.map and Array.filter
  
          * fast/js/array-every-expected.txt:
          * fast/js/array-every.html:
          * fast/js/array-foreach-expected.txt:
          * fast/js/array-foreach.html:
          Modify these tests since Array.every and Array.foreach now follow Mozilla
          and treat arrays as sparse, not visiting non-existing properties.
  
  Revision  Changes    Path
  1.192     +14 -0     LayoutTests/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/LayoutTests/ChangeLog,v
  retrieving revision 1.191
  retrieving revision 1.192
  diff -u -r1.191 -r1.192
  --- ChangeLog	27 Dec 2005 19:06:46 -0000	1.191
  +++ ChangeLog	27 Dec 2005 20:06:39 -0000	1.192
  @@ -1,3 +1,17 @@
  +2005-12-27  Anders Carlsson  <andersca at mac.com>
  +
  +        Reviewed by Darin.
  +
  +        - Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6250
  +        Implement Array.map and Array.filter
  +        
  +        * fast/js/array-every-expected.txt:
  +        * fast/js/array-every.html:
  +        * fast/js/array-foreach-expected.txt:
  +        * fast/js/array-foreach.html:
  +        Modify these tests since Array.every and Array.foreach now follow Mozilla
  +        and treat arrays as sparse, not visiting non-existing properties.
  +
   2005-12-27  Mitz Pettel  <opendarwin.org at mitzpettel.com>
   
           Reviewed by Maciej, landed by Darin.
  
  
  
  1.5       +2 -2      LayoutTests/fast/js/array-every-expected.txt
  
  Index: array-every-expected.txt
  ===================================================================
  RCS file: /cvs/root/LayoutTests/fast/js/array-every-expected.txt,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- array-every-expected.txt	28 Sep 2005 20:40:22 -0000	1.4
  +++ array-every-expected.txt	27 Dec 2005 20:06:40 -0000	1.5
  @@ -14,10 +14,10 @@
   These tests the affects of array mutation during execution of every.
   
   3.1 Array Element Removal
  -This test is equivalent to 1.0, with the exception that it removes elements from the array on each visit. Both should thus yield "false" since undefined is not >= to 10.
  +This test is equivalent to 1.0, with the exception that it removes elements from the array on each visit. The first test should thus yield "false" and the second test "true", since non-existing properties are not checked.
   
   false
  -false
  +true
   
   3.3 Array Element Addition
   This test is equivalent to 1.0, with that it test whether elements are >= 131 and it adds elements greater than 131 to the end of the list. However, both results should be false since every uses the original length to create the range it iterates over.
  
  
  
  1.3       +1 -1      LayoutTests/fast/js/array-every.html
  
  Index: array-every.html
  ===================================================================
  RCS file: /cvs/root/LayoutTests/fast/js/array-every.html,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- array-every.html	28 Sep 2005 20:40:22 -0000	1.2
  +++ array-every.html	27 Dec 2005 20:06:40 -0000	1.3
  @@ -41,7 +41,7 @@
   3.0 Array Mutation Tests<br/>
   These tests the affects of array mutation during execution of every.<br/><br/>
   3.1 Array Element Removal<br/>
  -This test is equivalent to 1.0, with the exception that it removes elements from the array on each visit.  Both should thus yield "false" since undefined is not >= to 10.<br/><br/>
  +This test is equivalent to 1.0, with the exception that it removes elements from the array on each visit.  The first test should thus yield "false" and the second test "true", since non-existing properties are not checked.<br/><br/>
   
   <script>
   function isBigEnoughAndPop(element, index, array) {
  
  
  
  1.4       +1 -2      LayoutTests/fast/js/array-foreach-expected.txt
  
  Index: array-foreach-expected.txt
  ===================================================================
  RCS file: /cvs/root/LayoutTests/fast/js/array-foreach-expected.txt,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- array-foreach-expected.txt	16 Jul 2005 05:39:25 -0000	1.3
  +++ array-foreach-expected.txt	27 Dec 2005 20:06:40 -0000	1.4
  @@ -16,11 +16,10 @@
   These tests the affects of array mutation during execution of forEach.
   
   3.1 Array Element Removal
  -This test removes elements from the array, these elements should thus appear as undefined when reached by forEach.
  +This test removes elements from the array, these elements should thus not appear since forEach doesn't iterate over non-existing properties.
   
   [0] is 2
   [1] is 5
  -[2] is undefined
   
   3.2 Array Element Addition
   This test adds elements to the array, these elements should not appear since forEach uses the original length to create the range it iterates over. It should be identical to 1.0.
  
  
  
  1.2       +1 -1      LayoutTests/fast/js/array-foreach.html
  
  Index: array-foreach.html
  ===================================================================
  RCS file: /cvs/root/LayoutTests/fast/js/array-foreach.html,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- array-foreach.html	30 Jun 2005 01:19:47 -0000	1.1
  +++ array-foreach.html	27 Dec 2005 20:06:40 -0000	1.2
  @@ -45,7 +45,7 @@
   3.0 Array Mutation Tests<br/>
   These tests the affects of array mutation during execution of forEach.<br/><br/>
   3.1 Array Element Removal<br/>
  -This test removes elements from the array, these elements should thus appear as undefined when reached by forEach.<br/><br/>
  +This test removes elements from the array, these elements should thus not appear since forEach doesn't iterate over non-existing properties.<br/><br/>
   
   <script>
   function printEltAndPop(element, index, array) {
  
  
  



More information about the webkit-changes mailing list