[webkit-changes] cvs commit: WebCore/manual-tests bugzilla-5699.html

Darin darin at opensource.apple.com
Tue Dec 27 11:13:41 PST 2005 

darin       05/12/27 11:13:40

  Modified:    .        ChangeLog
               khtml/rendering render_object.cpp
  Added:       manual-tests bugzilla-5699.html
  Log:
          Reviewed by Hyatt, landed by Darin.
  
          - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5699
            REGRESSION: incomplete repaint
  
          * khtml/rendering/render_object.cpp:
          (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the
          size changed and not everything was repainted.
          * manual-tests/bugzilla-5699.html: Added.
  
  Revision  Changes    Path
  1.47      +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.46
  retrieving revision 1.47
  diff -u -r1.46 -r1.47
  --- ChangeLog	27 Dec 2005 18:39:33 -0000	1.46
  +++ ChangeLog	27 Dec 2005 19:13:39 -0000	1.47
  @@ -1,3 +1,15 @@
  +2005-12-27  Mitz Pettel  <opendarwin.org at mitzpettel.com>
  +
  +        Reviewed by Hyatt, landed by Darin.
  +        
  +        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5699
  +          REGRESSION: incomplete repaint
  +
  +        * khtml/rendering/render_object.cpp:
  +        (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the
  +        size changed and not everything was repainted.
  +        * manual-tests/bugzilla-5699.html: Added.
  +
   2005-12-27  Sam Weinig  <sam.weinig at gmail.com>
   
           Reviewed by Maciej, landed by Darin.
  
  
  
  1.232     +1 -0      WebCore/khtml/rendering/render_object.cpp
  
  Index: render_object.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_object.cpp,v
  retrieving revision 1.231
  retrieving revision 1.232
  diff -u -r1.231 -r1.232
  --- render_object.cpp	21 Dec 2005 22:51:11 -0000	1.231
  +++ render_object.cpp	27 Dec 2005 19:13:40 -0000	1.232
  @@ -1452,6 +1452,7 @@
                                             kMin(newBounds.y() + newBounds.height(), oldBounds.y() + oldBounds.height()),
                                             kMax(newBounds.width(), oldBounds.width()),
                                             height));
  +        return false;
       }
       return true;
   }
  
  
  
  1.1                  WebCore/manual-tests/bugzilla-5699.html
  
  Index: bugzilla-5699.html
  ===================================================================
  <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
          "http://www.w3.org/TR/html4/strict.dtd">
  <html lang="en">
  <head>
  </head>
  <body>
  <p><b>BUG ID:</b> <a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=5699">Bugzilla bug 5699</a> REGRESSION: incomplete repaint</p>
  
  <p id="test" style="background-color:skyblue; padding:3px;"><b>STEPS TO TEST:</b> 
  Click the Test button below.
  </p>
  
  <p id="success" style="background-color:palegreen; padding:3px;"><b>TEST PASS:</b> 
  The word &ldquo;Hello&rdquo; will move down.
  </p>
  
  <p id="failure" style="background-color:#FF3300; padding:3px;"><b>TEST FAIL:</b>  
  Another copy of the word &ldquo;Hello&rdquo; will appear.
  </p>
  
  <button onclick="document.getElementById('d').style.lineHeight = 3">Test</button>
  <p>
  <span id="d">&nbsp;</span><br>
  Hello<br>
  </p>
  </body>
  </html>

More information about the webkit-changes mailing list