[webkit-changes] cvs commit: WebCore/khtml/xml dom2_eventsimpl.cpp

[Darin]

darin       05/12/27 10:05:03

  Modified:    .        ChangeLog
               khtml/xml dom2_eventsimpl.cpp
  Log:
          Fix suggested by Mitz.
  
          - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6240
            REGRESSION: scrollbars in overflows don't work
  
          * khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions):
          Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed
          in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part
          of my fix for clientX/Y in the original patch.
  
  Revision  Changes    Path
  1.44      +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- ChangeLog	27 Dec 2005 12:05:34 -0000	1.43
  +++ ChangeLog	27 Dec 2005 18:05:02 -0000	1.44
  @@ -1,3 +1,15 @@
  +2005-12-27  Darin Adler  <darin at apple.com>
  +
  +        Fix suggested by Mitz.
  +
  +        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6240
  +          REGRESSION: scrollbars in overflows don't work
  +
  +        * khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions):
  +        Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed
  +        in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part
  +        of my fix for clientX/Y in the original patch.
  +
   2005-12-27  Maks Orlovich <maksim at kde.org>
   
           Reviewed and landed by Maciej.
  
  
  
  1.43      +5 -2      WebCore/khtml/xml/dom2_eventsimpl.cpp
  
  Index: dom2_eventsimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom2_eventsimpl.cpp,v
  retrieving revision 1.42
  retrieving revision 1.43
  diff -u -r1.42 -r1.43
  --- dom2_eventsimpl.cpp	22 Dec 2005 04:06:45 -0000	1.42
  +++ dom2_eventsimpl.cpp	27 Dec 2005 18:05:02 -0000	1.43
  @@ -258,8 +258,11 @@
   
       doc->updateRendering();
   
  -    // Compute page position.
  -    kv->viewportToContents(m_clientX, m_clientY, m_pageX, m_pageY);
  +    // FIXME: clientX/Y should not be the same as pageX/Y!
  +    // Currently the passed-in clientX and clientY are incorrectly actually
  +    // pageX and pageY values, so we don't have any work to do here, but if
  +    // we started passing in correct clientX and clientY, we'd want to compute
  +    // pageX and pageY here.
   
       // Compute offset position.
       m_offsetX = m_pageX;