[webkit-changes] cvs commit: WebCore/khtml/dom dom_string.h

[Eric]

eseidel     05/12/24 21:11:06

  Modified:    .        ChangeLog
               khtml/dom dom_string.h
  Log:
  Bug #: 6326
  Submitted by: mitz
  Reviewed by: eseidel
          Test: fast/forms/domstring-replace-crash.html
  
          - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6236
            REGRESSION: Crash in DOMString::replace() in ToT (12/24/05)
  
          * khtml/dom/dom_string.h:
          (DOMString::replace): Added check for null m_impl.
  
  Revision  Changes    Path
  1.40      +13 -1     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.39
  retrieving revision 1.40
  diff -u -r1.39 -r1.40
  --- ChangeLog	24 Dec 2005 22:45:58 -0000	1.39
  +++ ChangeLog	25 Dec 2005 05:11:05 -0000	1.40
  @@ -1,4 +1,16 @@
  -2005-12-23  Maciej Stachowiak  <mjs at apple.com>
  +2005-12-24  Mitz Pettel  <opendarwin.org at mitzpettel.com>
  +
  +        Reviewed by eseidel.
  +        
  +        Test: fast/forms/domstring-replace-crash.html
  +
  +        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6236
  +          REGRESSION: Crash in DOMString::replace() in ToT (12/24/05)
  +
  +        * khtml/dom/dom_string.h:
  +        (DOMString::replace): Added check for null m_impl.
  +
  +2005-12-24  Maciej Stachowiak  <mjs at apple.com>
   
           Reviewed by Eric.
   
  
  
  
  1.18      +1 -1      WebCore/khtml/dom/dom_string.h
  
  Index: dom_string.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/dom/dom_string.h,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- dom_string.h	23 Dec 2005 18:44:08 -0000	1.17
  +++ dom_string.h	25 Dec 2005 05:11:05 -0000	1.18
  @@ -73,7 +73,7 @@
       const QChar &operator [](unsigned int i) const;
   
       int find(const QChar c, int start = 0) const;
  -    DOMString &replace(QChar a, QChar b) { m_impl = m_impl->replace(a, b); return *this; }
  +    DOMString &replace(QChar a, QChar b) { if (m_impl) m_impl = m_impl->replace(a, b); return *this; }
   
       uint length() const;
       void truncate( unsigned int len );