[webkit-changes] cvs commit: WebCore/khtml/rendering render_container.cpp

[Geoffrey]

ggaren      05/12/23 17:05:56

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml/rendering Tag: Safari-2-0-branch render_container.cpp
  Log:
          - Fixed <rdar://problem/4392583> REGRESSION: Reproducible crash while viewing Opera's "why we're better than Safari" site, http://www.howtocreate.co.uk/browserSpeed.html, in khtml::RenderBlock::nodeAtPoint
  
          Fix by Darin, reviewed and landed by me.
  
          * khtml/rendering/render_container.cpp:
          (RenderContainer::updatePseudoChild): Don't have the parent call removeChild, because the child calls parent()->removeChild() on itself in detach().
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.16.2.7  +9 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.16.2.6
  retrieving revision 1.16.2.7
  diff -u -r1.16.2.6 -r1.16.2.7
  --- ChangeLog	21 Dec 2005 22:42:36 -0000	1.16.2.6
  +++ ChangeLog	24 Dec 2005 01:05:55 -0000	1.16.2.7
  @@ -1,3 +1,12 @@
  +2005-12-23  Geoffrey Garen  <ggaren at apple.com>
  +
  +        - Fixed <rdar://problem/4392583> REGRESSION: Reproducible crash while viewing Opera's "why we're better than Safari" site, http://www.howtocreate.co.uk/browserSpeed.html, in khtml::RenderBlock::nodeAtPoint
  +
  +        Fix by Darin, reviewed and landed by me.
  +
  +        * khtml/rendering/render_container.cpp:
  +        (RenderContainer::updatePseudoChild): Don't have the parent call removeChild, because the child calls parent()->removeChild() on itself in detach().
  +
   === WebCore-417.17 ===
   
   2005-12-21  Adele Peterson  <adele at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.66.8.2  +0 -1      WebCore/khtml/rendering/render_container.cpp
  
  Index: render_container.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_container.cpp,v
  retrieving revision 1.66.8.1
  retrieving revision 1.66.8.2
  diff -u -r1.66.8.1 -r1.66.8.2
  --- render_container.cpp	28 Sep 2005 18:24:45 -0000	1.66.8.1
  +++ render_container.cpp	24 Dec 2005 01:05:55 -0000	1.66.8.2
  @@ -242,7 +242,6 @@
           // Nuke the child. 
           if (child && child->style()->styleType() == type) {
               oldContentPresent = false;
  -            removeChild(child);
               child->detach();
               child = (type == RenderStyle::BEFORE) ? firstChild() : lastChild();
           }