[webkit-changes] cvs commit: WebCore/khtml/xml dom_docimpl.cpp

[Adele]

adele       05/12/22 17:13:52

  Modified:    .        ChangeLog
               khtml/xml dom_docimpl.cpp
  Log:
          Reviewed by Darin.
  
          Cleaned up a previous checkin by defining global const defaultForm.
  
          * khtml/xml/dom_docimpl.cpp:
          (DocumentImpl::radioButtonChecked):
          (DocumentImpl::checkedRadioButtonForGroup):
          (DocumentImpl::removeRadioButtonGroup):
  
  Revision  Changes    Path
  1.29      +11 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- ChangeLog	22 Dec 2005 23:06:19 -0000	1.28
  +++ ChangeLog	23 Dec 2005 01:13:49 -0000	1.29
  @@ -1,5 +1,16 @@
   2005-12-22  Adele Peterson  <adele at apple.com>
   
  +        Reviewed by Darin.
  +
  +        Cleaned up a previous checkin by defining global const defaultForm.
  +
  +        * khtml/xml/dom_docimpl.cpp:
  +        (DocumentImpl::radioButtonChecked):
  +        (DocumentImpl::checkedRadioButtonForGroup):
  +        (DocumentImpl::removeRadioButtonGroup):
  +
  +2005-12-22  Adele Peterson  <adele at apple.com>
  +
           Reviewed by Tim Hatcher.
   
           Fixed <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings
  
  
  
  1.292     +6 -6      WebCore/khtml/xml/dom_docimpl.cpp
  
  Index: dom_docimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_docimpl.cpp,v
  retrieving revision 1.291
  retrieving revision 1.292
  diff -u -r1.291 -r1.292
  --- dom_docimpl.cpp	22 Dec 2005 23:06:21 -0000	1.291
  +++ dom_docimpl.cpp	23 Dec 2005 01:13:50 -0000	1.292
  @@ -113,6 +113,9 @@
   
   DOMImplementationImpl *DOMImplementationImpl::m_instance = 0;
   
  +// Use 1 to represent the document's default form.
  +HTMLFormElementImpl* const defaultForm = (HTMLFormElementImpl*) 1;
  +
   // DOM Level 2 says (letters added):
   //
   // a) Name start characters must have one of the categories Ll, Lu, Lo, Lt, Nl.
  @@ -3209,9 +3212,8 @@
       // Without a name, there is no group.
       if (caller->name().isEmpty())
           return;
  -    // Use 1 to represent the document's default form
       if (!form)
  -        form = (HTMLFormElementImpl*) 1;
  +        form = defaultForm;
       // Uncheck the currently selected item
       if (!m_selectedRadioButtons)
           m_selectedRadioButtons = new FormToGroupMap;
  @@ -3232,9 +3234,8 @@
   {
       if (!m_selectedRadioButtons)
           return 0;
  -    // Use 1 to represent the document's default form
       if (!form)
  -        form = (HTMLFormElementImpl*) 1;
  +        form = defaultForm;
       NameToInputMap* formRadioButtons = m_selectedRadioButtons->get(form);
       if (!formRadioButtons)
           return 0;
  @@ -3244,9 +3245,8 @@
   
   void DocumentImpl::removeRadioButtonGroup(DOMStringImpl* name, HTMLFormElementImpl *form)
   {
  -    // Use 1 to represent the document's default form
       if (!form)
  -        form = (HTMLFormElementImpl*) 1;
  +        form = defaultForm;
       if (m_selectedRadioButtons) {
           NameToInputMap* formRadioButtons = m_selectedRadioButtons->get(form);
           if (formRadioButtons) {