[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp

[Timothy]

thatcher    05/12/22 14:38:36

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               khtml/html Tag: Safari-1-3-branch html_formimpl.cpp
  Log:
          Merged fix from TOT to Safari-1-3-branch
  
      2005-12-21  Adele Peterson  <adele at apple.com>
  
          Reviewed by Tim Hatcher.
  
          Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings
  
          * khtml/html/html_formimpl.cpp:
          (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.18.2.4  +13 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.18.2.3
  retrieving revision 1.18.2.4
  diff -u -r1.18.2.3 -r1.18.2.4
  --- ChangeLog	22 Dec 2005 22:36:57 -0000	1.18.2.3
  +++ ChangeLog	22 Dec 2005 22:38:35 -0000	1.18.2.4
  @@ -2,6 +2,19 @@
   
           Merged fix from TOT to Safari-1-3-branch
   
  +    2005-12-21  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by Tim Hatcher.
  +
  +        Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings
  +
  +        * khtml/html/html_formimpl.cpp:
  +        (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
  +
  +2005-12-22  Timothy Hatcher  <timothy at apple.com>
  +
  +        Merged fix from TOT to Safari-1-3-branch
  +
       2005-12-20  Adele Peterson  <adele at apple.com>
   
           Reviewed by Darin.
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.156.4.9 +9 -0      WebCore/khtml/html/html_formimpl.cpp
  
  Index: html_formimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
  retrieving revision 1.156.4.8
  retrieving revision 1.156.4.9
  diff -u -r1.156.4.8 -r1.156.4.9
  --- html_formimpl.cpp	12 Dec 2005 23:49:52 -0000	1.156.4.8
  +++ html_formimpl.cpp	22 Dec 2005 22:38:35 -0000	1.156.4.9
  @@ -729,6 +729,15 @@
   
   void HTMLFormElementImpl::registerFormElement(HTMLGenericFormElementImpl *e)
   {
  +    DocumentImpl *doc = getDocument();
  +    if (!e->name().isEmpty() && doc) {        
  +        HTMLGenericFormElementImpl* currentCheckedRadio = doc->checkedRadioButtonForGroup(e->name(), (HTMLFormElementImpl*) 0);
  +        if (currentCheckedRadio == e) {
  +            doc->removeRadioButtonGroup(e->name(), (HTMLFormElementImpl*) 0);
  +            doc->radioButtonChecked((HTMLInputElementImpl*) e, this);
  +        }
  +    }
  +    
       appendToVector(formElements, e);
       removeFromVector(dormantFormElements, e);
   }