[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp
Adele
adele at opensource.apple.com
Wed Dec 21 13:57:16 PST 2005
adele 05/12/21 13:57:15
Modified: . Tag: Safari-2-0-branch ChangeLog
khtml/html Tag: Safari-2-0-branch html_formimpl.cpp
Log:
Reviewed by Tim Hatcher.
Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings
* khtml/html/html_formimpl.cpp:
(DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
Revision Changes Path
No revision
No revision
1.16.2.5 +9 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.16.2.4
retrieving revision 1.16.2.5
diff -u -r1.16.2.4 -r1.16.2.5
--- ChangeLog 21 Dec 2005 01:41:31 -0000 1.16.2.4
+++ ChangeLog 21 Dec 2005 21:57:13 -0000 1.16.2.5
@@ -1,3 +1,12 @@
+2005-12-21 Adele Peterson <adele at apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings
+
+ * khtml/html/html_formimpl.cpp:
+ (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
+
=== WebCore-417.16 ===
2005-12-20 Adele Peterson <adele at apple.com>
No revision
No revision
1.156.6.10 +9 -0 WebCore/khtml/html/html_formimpl.cpp
Index: html_formimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
retrieving revision 1.156.6.9
retrieving revision 1.156.6.10
diff -u -r1.156.6.9 -r1.156.6.10
--- html_formimpl.cpp 12 Dec 2005 23:48:00 -0000 1.156.6.9
+++ html_formimpl.cpp 21 Dec 2005 21:57:14 -0000 1.156.6.10
@@ -729,6 +729,15 @@
void HTMLFormElementImpl::registerFormElement(HTMLGenericFormElementImpl *e)
{
+ DocumentImpl *doc = getDocument();
+ if (!e->name().isEmpty() && doc) {
+ HTMLGenericFormElementImpl* currentCheckedRadio = doc->checkedRadioButtonForGroup(e->name(), (HTMLFormElementImpl*) 0);
+ if (currentCheckedRadio == e) {
+ doc->removeRadioButtonGroup(e->name(), (HTMLFormElementImpl*) 0);
+ doc->radioButtonChecked((HTMLInputElementImpl*) e, this);
+ }
+ }
+
appendToVector(formElements, e);
removeFromVector(dormantFormElements, e);
}
More information about the webkit-changes
mailing list