[webkit-changes] cvs commit: LayoutTests/fast/overflow
overflow-focus-ring-expected.checksum
overflow-focus-ring-expected.png overflow-focus-ring-expected.txt
Adele
adele at opensource.apple.com
Wed Dec 21 08:51:09 PST 2005
adele 05/12/21 08:51:08
Modified: . ChangeLog
khtml khtml_part.cpp khtml_part.h
khtml/html html_formimpl.cpp html_formimpl.h
khtml/xml dom_docimpl.cpp dom_elementimpl.cpp
kwq KWQKHTMLPart.mm
. ChangeLog
editing/selection focus_editable_html-expected.checksum
focus_editable_html-expected.png
focus_editable_html-expected.txt
fast/dom blur-contenteditable-expected.txt
focus-contenteditable-expected.checksum
focus-contenteditable-expected.png
focus-contenteditable-expected.txt
fast/overflow overflow-focus-ring-expected.checksum
overflow-focus-ring-expected.png
overflow-focus-ring-expected.txt
Log:
LayoutTests:
Reviewed by Darin.
Updating results for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
REGRESSION: Page scroll position jumps when clicking on word in editable div
These results all changed because we now select all for contenteditable elements when focus() is called on them.
* editing/selection/focus_editable_html-expected.checksum:
* editing/selection/focus_editable_html-expected.png:
* editing/selection/focus_editable_html-expected.txt:
* fast/dom/blur-contenteditable-expected.txt:
* fast/dom/focus-contenteditable-expected.checksum:
* fast/dom/focus-contenteditable-expected.png:
* fast/dom/focus-contenteditable-expected.txt:
* fast/overflow/overflow-focus-ring-expected.checksum:
* fast/overflow/overflow-focus-ring-expected.png:
* fast/overflow/overflow-focus-ring-expected.txt:
WebCore:
Reviewed by Darin.
Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
REGRESSION: Page scroll position jumps when clicking on word in editable div
I moved the scrolling code out of setFocusNode, and consolidated some of the focus code to scroll when necessary.
* khtml/html/html_formimpl.cpp: Removed HTMLButtonElementImpl::blur, HTMLButtonElementImpl::focus, HTMLInputElementImpl::blur, HTMLInputElementImpl::focus.
New code in ElementImpl::focus will now handle these cases. This allows tabbing through the elements to go through the same code path as calling focus() on an element.
Before, focus() would scroll to reveal for any form elements that had a RenderWidget, but wouldn't scroll for anchor elements, or any of the new form elements.
Now the behavior will be more consistent.
(DOM::HTMLLabelElementImpl::focus): calls ElementImpl::focus.
(DOM::HTMLLegendElementImpl::focus): ditto.
* khtml/html/html_formimpl.h:
* khtml/khtml_part.cpp:
(KHTMLPart::selectAll): calls new function selectContentsOfNode
(KHTMLPart::selectContentsOfNode): factored out code to selectAll for a particular node- which is useful for contenteditable elements.
* khtml/khtml_part.h: added selectContentsOfNode
* khtml/xml/dom_docimpl.cpp:
(DocumentImpl::setFocusNode): removed scrolling code.
* khtml/xml/dom_elementimpl.cpp:
(ElementImpl::focus): Calls updateLayout in case focus() is called before there's a renderer.
Makes a selection for editable elements (right now we select all, but this will change).
Doesn't scroll if the renderer is a RenderWidget, since that is handled when the view becomes first responder. This will go away when we convert the rest of our form elements.
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::revealSelection): Made this more like centerSelectionInVisibleArea where we get the right rectangle if the selection is a caret.
(KWQKHTMLPart::nextKeyViewInFrame): call ElementImpl::focus() for the node. This will set the selection too, which used to be done here.
Revision Changes Path
1.18 +30 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- ChangeLog 21 Dec 2005 02:05:11 -0000 1.17
+++ ChangeLog 21 Dec 2005 16:51:00 -0000 1.18
@@ -1,3 +1,33 @@
+2005-12-20 Adele Peterson <adele at apple.com>
+
+ Reviewed by Darin.
+
+ Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
+ REGRESSION: Page scroll position jumps when clicking on word in editable div
+
+ I moved the scrolling code out of setFocusNode, and consolidated some of the focus code to scroll when necessary.
+
+ * khtml/html/html_formimpl.cpp: Removed HTMLButtonElementImpl::blur, HTMLButtonElementImpl::focus, HTMLInputElementImpl::blur, HTMLInputElementImpl::focus.
+ New code in ElementImpl::focus will now handle these cases. This allows tabbing through the elements to go through the same code path as calling focus() on an element.
+ Before, focus() would scroll to reveal for any form elements that had a RenderWidget, but wouldn't scroll for anchor elements, or any of the new form elements.
+ Now the behavior will be more consistent.
+ (DOM::HTMLLabelElementImpl::focus): calls ElementImpl::focus.
+ (DOM::HTMLLegendElementImpl::focus): ditto.
+ * khtml/html/html_formimpl.h:
+ * khtml/khtml_part.cpp:
+ (KHTMLPart::selectAll): calls new function selectContentsOfNode
+ (KHTMLPart::selectContentsOfNode): factored out code to selectAll for a particular node- which is useful for contenteditable elements.
+ * khtml/khtml_part.h: added selectContentsOfNode
+ * khtml/xml/dom_docimpl.cpp:
+ (DocumentImpl::setFocusNode): removed scrolling code.
+ * khtml/xml/dom_elementimpl.cpp:
+ (ElementImpl::focus): Calls updateLayout in case focus() is called before there's a renderer.
+ Makes a selection for editable elements (right now we select all, but this will change).
+ Doesn't scroll if the renderer is a RenderWidget, since that is handled when the view becomes first responder. This will go away when we convert the rest of our form elements.
+ * kwq/KWQKHTMLPart.mm:
+ (KWQKHTMLPart::revealSelection): Made this more like centerSelectionInVisibleArea where we get the right rectangle if the selection is a caret.
+ (KWQKHTMLPart::nextKeyViewInFrame): call ElementImpl::focus() for the node. This will set the selection too, which used to be done here.
+
2005-12-20 Alexey Proskuryakov <ap at nypop.com>
Reviewed by justin
1.371 +11 -5 WebCore/khtml/khtml_part.cpp
Index: khtml_part.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/khtml_part.cpp,v
retrieving revision 1.370
retrieving revision 1.371
diff -u -r1.370 -r1.371
--- khtml_part.cpp 20 Dec 2005 08:49:45 -0000 1.370
+++ khtml_part.cpp 21 Dec 2005 16:51:00 -0000 1.371
@@ -2706,15 +2706,21 @@
NodeImpl *startNode = d->m_selection.start().node();
NodeImpl *root = startNode && startNode->isContentEditable() ? startNode->rootEditableElement() : d->m_doc->documentElement();
-
- SelectionController sel = SelectionController(Position(root, 0), khtml::DOWNSTREAM, Position(root, root->maxDeepOffset()), khtml::DOWNSTREAM);
- if (shouldChangeSelection(sel))
- setSelection(sel);
-
+ selectContentsOfNode(root);
selectFrameElementInParentIfFullySelected();
}
+bool KHTMLPart::selectContentsOfNode(NodeImpl* node)
+{
+ SelectionController sel = SelectionController(Position(node, 0), khtml::DOWNSTREAM, Position(node, node->maxDeepOffset()), khtml::DOWNSTREAM);
+ if (shouldChangeSelection(sel)) {
+ setSelection(sel);
+ return true;
+ }
+ return false;
+}
+
bool KHTMLPart::shouldChangeSelection(const SelectionController &newselection) const
{
return KWQ(this)->shouldChangeSelection(d->m_selection, newselection, newselection.startAffinity(), false);
1.146 +6 -0 WebCore/khtml/khtml_part.h
Index: khtml_part.h
===================================================================
RCS file: /cvs/root/WebCore/khtml/khtml_part.h,v
retrieving revision 1.145
retrieving revision 1.146
diff -u -r1.145 -r1.146
--- khtml_part.h 16 Dec 2005 08:08:11 -0000 1.145
+++ khtml_part.h 21 Dec 2005 16:51:00 -0000 1.146
@@ -661,6 +661,12 @@
void selectAll();
/**
+ * Marks contents of node as selected.
+ * Returns whether the selection changed.
+ */
+ bool selectContentsOfNode(DOM::NodeImpl*);
+
+ /**
* Returns whether editing should end in the given range
*/
virtual bool shouldBeginEditing(const DOM::RangeImpl *) const;
1.214 +2 -46 WebCore/khtml/html/html_formimpl.cpp
Index: html_formimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
retrieving revision 1.213
retrieving revision 1.214
diff -u -r1.213 -r1.214
--- html_formimpl.cpp 20 Dec 2005 09:16:45 -0000 1.213
+++ html_formimpl.cpp 21 Dec 2005 16:51:01 -0000 1.214
@@ -1041,17 +1041,6 @@
return getAttribute(typeAttr);
}
-void HTMLButtonElementImpl::blur()
-{
- if(getDocument()->focusNode() == this)
- getDocument()->setFocusNode(0);
-}
-
-void HTMLButtonElementImpl::focus()
-{
- getDocument()->setFocusNode(this);
-}
-
void HTMLButtonElementImpl::parseMappedAttribute(MappedAttributeImpl *attr)
{
if (attr->name() == typeAttr) {
@@ -2018,17 +2007,6 @@
return false;
}
-void HTMLInputElementImpl::blur()
-{
- if(getDocument()->focusNode() == this)
- getDocument()->setFocusNode(0);
-}
-
-void HTMLInputElementImpl::focus()
-{
- getDocument()->setFocusNode(this);
-}
-
void* HTMLInputElementImpl::preDispatchEventHandler(EventImpl *evt)
{
// preventDefault or "return false" are used to reverse the automatic checking/selection we do here.
@@ -2390,7 +2368,7 @@
void HTMLLabelElementImpl::focus()
{
if (ElementImpl *element = formElement())
- getDocument()->setFocusNode(element);
+ element->focus();
}
void HTMLLabelElementImpl::accessKeyAction(bool sendToAnyElement)
@@ -2502,7 +2480,7 @@
void HTMLLegendElementImpl::focus()
{
if (ElementImpl *element = formElement())
- getDocument()->setFocusNode(element);
+ element->focus();
}
void HTMLLegendElementImpl::accessKeyAction(bool sendToAnyElement)
@@ -2638,17 +2616,6 @@
setRecalcListItems();
}
-void HTMLSelectElementImpl::blur()
-{
- if(getDocument()->focusNode() == this)
- getDocument()->setFocusNode(0);
-}
-
-void HTMLSelectElementImpl::focus()
-{
- getDocument()->setFocusNode(this);
-}
-
DOMString HTMLSelectElementImpl::value()
{
uint i;
@@ -3469,17 +3436,6 @@
setValue(defaultValue);
}
-void HTMLTextAreaElementImpl::blur()
-{
- if(getDocument()->focusNode() == this)
- getDocument()->setFocusNode(0);
-}
-
-void HTMLTextAreaElementImpl::focus()
-{
- getDocument()->setFocusNode(this);
-}
-
bool HTMLTextAreaElementImpl::isEditable()
{
return true;
1.99 +0 -10 WebCore/khtml/html/html_formimpl.h
Index: html_formimpl.h
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.h,v
retrieving revision 1.98
retrieving revision 1.99
diff -u -r1.98 -r1.99
--- html_formimpl.h 15 Dec 2005 22:31:39 -0000 1.98
+++ html_formimpl.h 21 Dec 2005 16:51:02 -0000 1.99
@@ -259,9 +259,6 @@
DOMString value() const;
void setValue(const DOMString &);
-
- void blur();
- void focus();
protected:
DOMString m_value;
@@ -355,9 +352,6 @@
bool valueMatchesRenderer() const { return m_valueMatchesRenderer; }
void setValueMatchesRenderer() { m_valueMatchesRenderer = true; }
- void blur();
- void focus();
-
virtual bool maintainsState() { return m_type != PASSWORD; }
virtual QString state();
virtual void restoreState(QStringList &);
@@ -560,8 +554,6 @@
void add ( HTMLElementImpl *element, HTMLElementImpl *before, int &exceptioncode );
void remove ( int index );
- void blur();
- void focus();
DOMString value();
void setValue(const DOMString &);
@@ -766,8 +758,6 @@
void setValue(const DOMString &value);
DOMString defaultValue();
void setDefaultValue(const DOMString &value);
- void blur();
- void focus();
void invalidateValue() { m_valueIsValid = false; }
void updateValue();
1.289 +1 -7 WebCore/khtml/xml/dom_docimpl.cpp
Index: dom_docimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/xml/dom_docimpl.cpp,v
retrieving revision 1.288
retrieving revision 1.289
diff -u -r1.288 -r1.289
--- dom_docimpl.cpp 20 Dec 2005 08:49:49 -0000 1.288
+++ dom_docimpl.cpp 21 Dec 2005 16:51:02 -0000 1.289
@@ -2329,14 +2329,8 @@
}
if (focusWidget)
focusWidget->setFocus();
- else {
+ else
view()->setFocus();
- // updateLayout in case this comes before a renderer is set up.
- updateLayout();
- // Check that there's still a renderer after updating the layout.
- if (m_focusNode->renderer())
- m_focusNode->renderer()->enclosingLayer()->scrollRectToVisible(m_focusNode->getRect());
- }
}
}
1.104 +12 -2 WebCore/khtml/xml/dom_elementimpl.cpp
Index: dom_elementimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/xml/dom_elementimpl.cpp,v
retrieving revision 1.103
retrieving revision 1.104
diff -u -r1.103 -r1.104
--- dom_elementimpl.cpp 20 Dec 2005 21:18:28 -0000 1.103
+++ dom_elementimpl.cpp 21 Dec 2005 16:51:03 -0000 1.104
@@ -792,8 +792,18 @@
void ElementImpl::focus()
{
DocumentImpl* doc = getDocument();
- if (doc && isFocusable())
- doc->setFocusNode(this);
+ if (doc) {
+ doc->updateLayout();
+ if (isFocusable()) {
+ doc->setFocusNode(this);
+ if (isContentEditable()) {
+ // FIXME: we should restore the previous selection if there is one, instead of always selecting all.
+ if (KWQ(doc->part())->selectContentsOfNode(this))
+ KWQ(doc->part())->revealSelection();
+ } else if (renderer() && !renderer()->isWidget())
+ renderer()->enclosingLayer()->scrollRectToVisible(getRect());
+ }
+ }
}
void ElementImpl::blur()
1.710 +26 -19 WebCore/kwq/KWQKHTMLPart.mm
Index: KWQKHTMLPart.mm
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQKHTMLPart.mm,v
retrieving revision 1.709
retrieving revision 1.710
diff -u -r1.709 -r1.710
--- KWQKHTMLPart.mm 21 Dec 2005 00:48:56 -0000 1.709
+++ KWQKHTMLPart.mm 21 Dec 2005 16:51:04 -0000 1.710
@@ -856,13 +856,27 @@
void KWQKHTMLPart::revealSelection()
{
- if (d->m_selection.start().isNotNull()) {
- if (selectionStart() && selectionStart()->renderer()) {
- RenderLayer *layer = selectionStart()->renderer()->enclosingLayer();
- if (layer) {
- ASSERT(!selectionEnd() || !selectionEnd()->renderer() || (selectionEnd()->renderer()->enclosingLayer() == layer));
- layer->scrollRectToVisible(selectionRect());
- }
+ QRect rect;
+
+ switch (selection().state()) {
+ case SelectionController::NONE:
+ return;
+
+ case SelectionController::CARET:
+ rect = selection().caretRect();
+ break;
+
+ case SelectionController::RANGE:
+ rect = selectionRect();
+ break;
+ }
+
+ ASSERT(d->m_selection.start().isNotNull());
+ if (selectionStart() && selectionStart()->renderer()) {
+ RenderLayer *layer = selectionStart()->renderer()->enclosingLayer();
+ if (layer) {
+ ASSERT(!selectionEnd() || !selectionEnd()->renderer() || (selectionEnd()->renderer()->enclosingLayer() == layer));
+ layer->scrollRectToVisible(rect);
}
}
}
@@ -1195,18 +1209,11 @@
if (view) {
return view;
}
- }
- else {
- doc->setFocusNode(node);
- if (node->isEditableBlock()) {
- SelectionController sel(Position(node, 0), DOWNSTREAM, Position(node, node->maxDeepOffset()), DOWNSTREAM);
- if (KHTMLPart::shouldChangeSelection(sel))
- setSelection(sel);
- }
-
- [_bridge makeFirstResponder:[_bridge documentView]];
- return [_bridge documentView];
- }
+ } else {
+ static_cast<ElementImpl *>(node)->focus();
+ }
+ [_bridge makeFirstResponder:[_bridge documentView]];
+ return [_bridge documentView];
}
}
1.178 +21 -0 LayoutTests/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/LayoutTests/ChangeLog,v
retrieving revision 1.177
retrieving revision 1.178
diff -u -r1.177 -r1.178
--- ChangeLog 21 Dec 2005 10:53:16 -0000 1.177
+++ ChangeLog 21 Dec 2005 16:51:06 -0000 1.178
@@ -1,3 +1,24 @@
+2005-12-21 Adele Peterson <adele at apple.com>
+
+ Reviewed by Darin.
+
+ Updating results for:
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
+ REGRESSION: Page scroll position jumps when clicking on word in editable div
+
+ These results all changed because we now select all for contenteditable elements when focus() is called on them.
+
+ * editing/selection/focus_editable_html-expected.checksum:
+ * editing/selection/focus_editable_html-expected.png:
+ * editing/selection/focus_editable_html-expected.txt:
+ * fast/dom/blur-contenteditable-expected.txt:
+ * fast/dom/focus-contenteditable-expected.checksum:
+ * fast/dom/focus-contenteditable-expected.png:
+ * fast/dom/focus-contenteditable-expected.txt:
+ * fast/overflow/overflow-focus-ring-expected.checksum:
+ * fast/overflow/overflow-focus-ring-expected.png:
+ * fast/overflow/overflow-focus-ring-expected.txt:
+
2005-12-21 Eric Seidel <eseidel at apple.com>
Fixed ChangeLog typo.
1.2 +1 -1 LayoutTests/editing/selection/focus_editable_html-expected.checksum
Index: focus_editable_html-expected.checksum
===================================================================
RCS file: /cvs/root/LayoutTests/editing/selection/focus_editable_html-expected.checksum,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- focus_editable_html-expected.checksum 1 Dec 2005 23:45:13 -0000 1.1
+++ focus_editable_html-expected.checksum 21 Dec 2005 16:51:06 -0000 1.2
@@ -1 +1 @@
-4f147eea252b5d96986624026e8cae2c
\ No newline at end of file
+4f88feb4e7fd895bad022515bdc3256e
\ No newline at end of file
1.2 +14 -26 LayoutTests/editing/selection/focus_editable_html-expected.png
<<Binary file>>
1.2 +4 -0 LayoutTests/editing/selection/focus_editable_html-expected.txt
Index: focus_editable_html-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/editing/selection/focus_editable_html-expected.txt,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- focus_editable_html-expected.txt 1 Dec 2005 23:45:14 -0000 1.1
+++ focus_editable_html-expected.txt 21 Dec 2005 16:51:07 -0000 1.2
@@ -1,4 +1,6 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of HTML > #document to 1 of HTML > #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of #text > BODY > HTML > #document to 42 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
layer at (0,0) size 2008x2070
RenderCanvas at (0,0) size 785x585
layer at (0,0) size 2008x2070
@@ -15,3 +17,5 @@
RenderText {TEXT} at (0,0) size 237x18
text run at (0,0) width 237: "If the document scrolls here, test fails."
RenderText {TEXT} at (0,0) size 0x0
+selection start: position 1 of child 0 {TEXT} of child 0 {BODY} of child 0 {HTML} of document
+selection end: position 42 of child 4 {TEXT} of child 0 {BODY} of child 0 {HTML} of document
1.2 +3 -0 LayoutTests/fast/dom/blur-contenteditable-expected.txt
Index: blur-contenteditable-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/fast/dom/blur-contenteditable-expected.txt,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- blur-contenteditable-expected.txt 15 Nov 2005 02:05:37 -0000 1.1
+++ blur-contenteditable-expected.txt 21 Dec 2005 16:51:07 -0000 1.2
@@ -1,5 +1,8 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 19 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldEndEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
1.2 +1 -1 LayoutTests/fast/dom/focus-contenteditable-expected.checksum
Index: focus-contenteditable-expected.checksum
===================================================================
RCS file: /cvs/root/LayoutTests/fast/dom/focus-contenteditable-expected.checksum,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- focus-contenteditable-expected.checksum 15 Nov 2005 02:05:37 -0000 1.1
+++ focus-contenteditable-expected.checksum 21 Dec 2005 16:51:07 -0000 1.2
@@ -1 +1 @@
-ff8ef386c92b498b42277fc80caccb67
\ No newline at end of file
+634b1cca7fb01687ba2678bc2dd1bd71
\ No newline at end of file
1.2 +6 -6 LayoutTests/fast/dom/focus-contenteditable-expected.png
<<Binary file>>
1.2 +4 -0 LayoutTests/fast/dom/focus-contenteditable-expected.txt
Index: focus-contenteditable-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/fast/dom/focus-contenteditable-expected.txt,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- focus-contenteditable-expected.txt 15 Nov 2005 02:05:37 -0000 1.1
+++ focus-contenteditable-expected.txt 21 Dec 2005 16:51:07 -0000 1.2
@@ -1,4 +1,6 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 19 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
layer at (0,0) size 785x894
RenderCanvas at (0,0) size 785x600
layer at (0,0) size 785x894
@@ -18,3 +20,5 @@
RenderText {TEXT} at (0,0) size 78x18
text run at (0,0) width 78: "Test Passed."
RenderBlock {DIV} at (0,878) size 769x0
+selection start: position 0 of child 0 {TEXT} of child 5 {DIV} of child 1 {BODY} of child 0 {HTML} of document
+selection end: position 19 of child 0 {TEXT} of child 5 {DIV} of child 1 {BODY} of child 0 {HTML} of document
1.2 +1 -1 LayoutTests/fast/overflow/overflow-focus-ring-expected.checksum
Index: overflow-focus-ring-expected.checksum
===================================================================
RCS file: /cvs/root/LayoutTests/fast/overflow/overflow-focus-ring-expected.checksum,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- overflow-focus-ring-expected.checksum 15 Dec 2005 21:06:50 -0000 1.1
+++ overflow-focus-ring-expected.checksum 21 Dec 2005 16:51:08 -0000 1.2
@@ -1 +1 @@
-55221f173a95b8e34e811c306c9d58a0
\ No newline at end of file
+b2c48d5532057dacc29a0f972c29469d
\ No newline at end of file
1.2 +3 -4 LayoutTests/fast/overflow/overflow-focus-ring-expected.png
<<Binary file>>
1.2 +4 -0 LayoutTests/fast/overflow/overflow-focus-ring-expected.txt
Index: overflow-focus-ring-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/fast/overflow/overflow-focus-ring-expected.txt,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- overflow-focus-ring-expected.txt 15 Dec 2005 21:06:50 -0000 1.1
+++ overflow-focus-ring-expected.txt 21 Dec 2005 16:51:08 -0000 1.2
@@ -1,4 +1,6 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 4428 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
@@ -11,3 +13,5 @@
RenderBlock {DIV} at (0,18) size 500x400
RenderText {TEXT} at (0,0) size 17712x18
text run at (0,0) width 17712: ".....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................"
+selection start: position 0 of child 0 {TEXT} of child 1 {DIV} of child 0 {BODY} of child 0 {HTML} of document
+selection end: position 4428 of child 0 {TEXT} of child 1 {DIV} of child 0 {BODY} of child 0 {HTML} of document
More information about the webkit-changes
mailing list