[webkit-changes] cvs commit: WebCore/kwq KWQKHTMLPart.mm

[Adele]

adele       05/12/20 17:36:23

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml/xml Tag: Safari-2-0-branch dom_elementimpl.cpp
               kwq      Tag: Safari-2-0-branch KWQKHTMLPart.mm
  Log:
          Reviewed by Darin.
  
          Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com
  
          * kwq/KWQKHTMLPart.mm:
          (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.16.2.3  +8 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.16.2.2
  retrieving revision 1.16.2.3
  diff -u -r1.16.2.2 -r1.16.2.3
  --- ChangeLog	21 Dec 2005 01:31:19 -0000	1.16.2.2
  +++ ChangeLog	21 Dec 2005 01:36:15 -0000	1.16.2.3
  @@ -1,3 +1,11 @@
  +2005-12-20  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by Darin.
  +
  +        Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com
  +
  +        * kwq/KWQKHTMLPart.mm:
  +        (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
   
   == Rolled over to ChangeLog-2005-12-19 ==
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.61.6.7  +5 -3      WebCore/khtml/xml/dom_elementimpl.cpp
  
  Index: dom_elementimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_elementimpl.cpp,v
  retrieving revision 1.61.6.6
  retrieving revision 1.61.6.7
  diff -u -r1.61.6.6 -r1.61.6.7
  --- dom_elementimpl.cpp	9 Dec 2005 04:09:59 -0000	1.61.6.6
  +++ dom_elementimpl.cpp	21 Dec 2005 01:36:16 -0000	1.61.6.7
  @@ -273,10 +273,12 @@
   void ElementImpl::focus()
   {
       DocumentImpl *doc = getDocument();
  -    if (doc)
  +    if (doc) {
           doc->updateLayout();
  -    if (isFocusable() && renderer()) {
  -        renderer()->enclosingLayer()->scrollRectToVisible(getRect());
  +        if (isFocusable() && renderer()) {
  +            doc->setFocusNode(this);
  +            renderer()->enclosingLayer()->scrollRectToVisible(getRect());
  +        }
       }
   }
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.628.6.16 +3 -0      WebCore/kwq/KWQKHTMLPart.mm
  
  Index: KWQKHTMLPart.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQKHTMLPart.mm,v
  retrieving revision 1.628.6.15
  retrieving revision 1.628.6.16
  diff -u -r1.628.6.15 -r1.628.6.16
  --- KWQKHTMLPart.mm	9 Dec 2005 04:10:01 -0000	1.628.6.15
  +++ KWQKHTMLPart.mm	21 Dec 2005 01:36:18 -0000	1.628.6.16
  @@ -2573,6 +2573,9 @@
               if (!renderer || !renderer->isWidget()) {
                   return false;
               }
  +            QWidget *widget = static_cast<RenderWidget *>(renderer)->widget();
  +            if (!widget || !widget->inherits("KHTMLView"))
  +                return false;
               if (!passWidgetMouseDownEventToWidget(static_cast<RenderWidget *>(renderer))) {
                   return false;
               }