[webkit-changes] cvs commit: WebCore/kwq KWQKHTMLPart.mm
Adele
adele at opensource.apple.com
Tue Dec 20 16:48:58 PST 2005
adele 05/12/20 16:48:58
Modified: . ChangeLog
kwq KWQKHTMLPart.mm
Log:
Reviewed by Darin.
Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
Revision Changes Path
1.16 +9 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- ChangeLog 20 Dec 2005 23:05:44 -0000 1.15
+++ ChangeLog 21 Dec 2005 00:48:55 -0000 1.16
@@ -1,3 +1,12 @@
+2005-12-20 Adele Peterson <adele at apple.com>
+
+ Reviewed by Darin.
+
+ Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com
+
+ * kwq/KWQKHTMLPart.mm:
+ (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
+
2005-12-20 Justin Garcia <justin.garcia at apple.com>
Reviewed by eric, thatcher
1.709 +4 -1 WebCore/kwq/KWQKHTMLPart.mm
Index: KWQKHTMLPart.mm
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQKHTMLPart.mm,v
retrieving revision 1.708
retrieving revision 1.709
diff -u -r1.708 -r1.709
--- KWQKHTMLPart.mm 21 Dec 2005 00:00:21 -0000 1.708
+++ KWQKHTMLPart.mm 21 Dec 2005 00:48:56 -0000 1.709
@@ -2527,7 +2527,7 @@
if (!renderer || !renderer->isWidget())
return false;
QWidget *widget = static_cast<RenderWidget *>(renderer)->widget();
- if (!widget || !widget->inherits("KHTMLView"))
+ if (!widget || !widget->isKHTMLView())
return false;
KHTMLPart *subframePart = static_cast<KHTMLView *>(widget)->part();
if (!subframePart)
@@ -2545,6 +2545,9 @@
if (!renderer || !renderer->isWidget()) {
return false;
}
+ QWidget *widget = static_cast<RenderWidget *>(renderer)->widget();
+ if (!widget || !widget->isKHTMLView())
+ return false;
if (!passWidgetMouseDownEventToWidget(static_cast<RenderWidget *>(renderer))) {
return false;
}
More information about the webkit-changes
mailing list