[webkit-changes] cvs commit: WebCore/khtml/xml dom_elementimpl.cpp

[Maciej]

mjs         05/12/20 12:40:44

  Modified:    .        ChangeLog
               khtml/xml dom_elementimpl.cpp
  Log:
          Reviewed by Darin.
  
          - fixed leak in createAttributeMap
  	http://bugzilla.opendarwin.org/show_bug.cgi?id=6162
  
          * khtml/xml/dom_elementimpl.cpp:
          (StyledElementImpl::createAttributeMap): the new attribute map
  	is going in a RefPtr, don't also ref it manually.
  
  Revision  Changes    Path
  1.12      +11 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- ChangeLog	20 Dec 2005 20:12:49 -0000	1.11
  +++ ChangeLog	20 Dec 2005 20:40:42 -0000	1.12
  @@ -2,6 +2,17 @@
   
           Reviewed by Darin.
   
  +        - fixed leak in createAttributeMap
  +	http://bugzilla.opendarwin.org/show_bug.cgi?id=6162
  +	
  +        * khtml/xml/dom_elementimpl.cpp:
  +        (StyledElementImpl::createAttributeMap): the new attribute map
  +	is going in a RefPtr, don't also ref it manually.
  +
  +2005-12-20  Maciej Stachowiak  <mjs at apple.com>
  +
  +        Reviewed by Darin.
  +
           - change an assignment to a contructor declaration to build with PassRefPtr
   	leak fix changes
   
  
  
  
  1.102     +0 -1      WebCore/khtml/xml/dom_elementimpl.cpp
  
  Index: dom_elementimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_elementimpl.cpp,v
  retrieving revision 1.101
  retrieving revision 1.102
  diff -u -r1.101 -r1.102
  --- dom_elementimpl.cpp	20 Dec 2005 20:27:15 -0000	1.101
  +++ dom_elementimpl.cpp	20 Dec 2005 20:40:43 -0000	1.102
  @@ -1397,7 +1397,6 @@
   void StyledElementImpl::createAttributeMap() const
   {
       namedAttrMap = new NamedMappedAttrMapImpl(const_cast<StyledElementImpl*>(this));
  -    namedAttrMap->ref();
   }
   
   CSSMutableStyleDeclarationImpl* StyledElementImpl::getInlineStyleDecl()