[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp
htmlparser.cpp
Eric
eseidel at opensource.apple.com
Tue Dec 20 01:16:47 PST 2005
eseidel 05/12/20 01:16:47
Modified: . ChangeLog
khtml/css css_stylesheetimpl.cpp
khtml/html html_formimpl.cpp htmlparser.cpp
Log:
Bug #: 5931
Submitted by: eseidel
Reviewed by: darin
Remove additional bit-rotted DEBUG* ifdefs from WebCore.
This removes PARSER_DEBUG, FORMS_DEBUG and CSS_STYLESHEET_DEBUG.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5931
No tests possible, only removing dead code.
* khtml/css/css_stylesheetimpl.cpp:
(CSSStyleSheetImpl::parseString):
(CSSStyleSheetImpl::isLoading):
* khtml/html/html_formimpl.cpp:
(DOM::HTMLFormElementImpl::formData):
(DOM::HTMLFormElementImpl::submit):
(DOM::HTMLFormElementImpl::reset):
(DOM::HTMLGenericFormElementImpl::getForm):
* khtml/html/htmlparser.cpp:
(HTMLParser::processCloseTag):
(HTMLParser::createHead):
Revision Changes Path
1.8 +21 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- ChangeLog 20 Dec 2005 08:49:45 -0000 1.7
+++ ChangeLog 20 Dec 2005 09:16:43 -0000 1.8
@@ -2,6 +2,27 @@
Reviewed by darin.
+ Remove additional bit-rotted DEBUG* ifdefs from WebCore.
+ This removes PARSER_DEBUG, FORMS_DEBUG and CSS_STYLESHEET_DEBUG.
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=5931
+ No tests possible, only removing dead code.
+
+ * khtml/css/css_stylesheetimpl.cpp:
+ (CSSStyleSheetImpl::parseString):
+ (CSSStyleSheetImpl::isLoading):
+ * khtml/html/html_formimpl.cpp:
+ (DOM::HTMLFormElementImpl::formData):
+ (DOM::HTMLFormElementImpl::submit):
+ (DOM::HTMLFormElementImpl::reset):
+ (DOM::HTMLGenericFormElementImpl::getForm):
+ * khtml/html/htmlparser.cpp:
+ (HTMLParser::processCloseTag):
+ (HTMLParser::createHead):
+
+2005-12-20 Eric Seidel <eseidel at apple.com>
+
+ Reviewed by darin.
+
Move Decoder onto Shared<T> and clients onto RefPtr.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6107
No test cases possible, no functional changes.
1.21 +1 -11 WebCore/khtml/css/css_stylesheetimpl.cpp
Index: css_stylesheetimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/css/css_stylesheetimpl.cpp,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- css_stylesheetimpl.cpp 15 Dec 2005 21:39:56 -0000 1.20
+++ css_stylesheetimpl.cpp 20 Dec 2005 09:16:44 -0000 1.21
@@ -19,7 +19,7 @@
* the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
* Boston, MA 02111-1307, USA.
*
- * $Id: css_stylesheetimpl.cpp,v 1.20 2005/12/15 21:39:56 eseidel Exp $
+ * $Id: css_stylesheetimpl.cpp,v 1.21 2005/12/20 09:16:44 eseidel Exp $
*/
//#define CSS_STYLESHEET_DEBUG
@@ -225,10 +225,6 @@
bool CSSStyleSheetImpl::parseString(const DOMString &string, bool strict)
{
-#ifdef CSS_STYLESHEET_DEBUG
- kdDebug( 6080 ) << "parsing sheet, len=" << string.length() << ", sheet is " << string.qstring() << endl;
-#endif
-
strictParsing = strict;
CSSParser p( strict );
p.parseSheet( this, string );
@@ -243,14 +239,8 @@
if (rule->isImportRule())
{
CSSImportRuleImpl *import = static_cast<CSSImportRuleImpl *>(rule);
-#ifdef CSS_STYLESHEET_DEBUG
- kdDebug( 6080 ) << "found import" << endl;
-#endif
if (import->isLoading())
{
-#ifdef CSS_STYLESHEET_DEBUG
- kdDebug( 6080 ) << "--> not loaded" << endl;
-#endif
return true;
}
}
1.213 +0 -15 WebCore/khtml/html/html_formimpl.cpp
Index: html_formimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
retrieving revision 1.212
retrieving revision 1.213
diff -u -r1.212 -r1.213
--- html_formimpl.cpp 16 Dec 2005 08:08:17 -0000 1.212
+++ html_formimpl.cpp 20 Dec 2005 09:16:45 -0000 1.213
@@ -299,10 +299,6 @@
bool HTMLFormElementImpl::formData(FormData &form_data) const
{
-#ifdef FORMS_DEBUG
- kdDebug( 6030 ) << "form: formData()" << endl;
-#endif
-
QCString enc_string = ""; // used for non-multipart data
// find out the QTextcodec to use
@@ -474,10 +470,6 @@
m_insubmit = true;
-#ifdef FORMS_DEBUG
- kdDebug( 6030 ) << "submitting!" << endl;
-#endif
-
HTMLGenericFormElementImpl* firstSuccessfulSubmitButton = 0;
bool needButtonActivation = activateSubmitButton; // do we need to activate a submit button?
@@ -539,10 +531,6 @@
m_inreset = true;
-#ifdef FORMS_DEBUG
- kdDebug( 6030 ) << "reset pressed!" << endl;
-#endif
-
// ### DOM2 labels this event as not cancelable, however
// common browsers( sick! ) allow it be cancelled.
if ( !dispatchHTMLEvent(resetEvent,true, true) ) {
@@ -868,9 +856,6 @@
return static_cast<HTMLFormElementImpl *>(p);
p = p->parentNode();
}
-#ifdef FORMS_DEBUG
- kdDebug( 6030 ) << "couldn't find form!" << endl;
-#endif
return 0;
}
1.126 +0 -6 WebCore/khtml/html/htmlparser.cpp
Index: htmlparser.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/htmlparser.cpp,v
retrieving revision 1.125
retrieving revision 1.126
diff -u -r1.125 -r1.126
--- htmlparser.cpp 19 Dec 2005 20:41:45 -0000 1.125
+++ htmlparser.cpp 20 Dec 2005 09:16:45 -0000 1.126
@@ -837,9 +837,6 @@
parseToken(t);
popBlock(t->tagName);
}
-#ifdef PARSER_DEBUG
- kdDebug( 6035 ) << "closeTag --> current = " << current->nodeName().qstring() << endl;
-#endif
}
bool HTMLParser::isHeaderTag(const AtomicString& tagName)
@@ -1291,9 +1288,6 @@
int exceptioncode = 0;
doc()->firstChild()->insertBefore(head, body, exceptioncode);
if ( exceptioncode ) {
-#ifdef PARSER_DEBUG
- kdDebug( 6035 ) << "creation of head failed!!!!" << endl;
-#endif
head = 0;
}
}
More information about the webkit-changes
mailing list