[webkit-changes] cvs commit: WebCore/khtml khtml_part.cpp

[Adele]

adele       05/12/16 12:35:51

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml    Tag: Safari-2-0-branch khtml_part.cpp
  Log:
          Reviewed by Maciej.
  
          Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()
  
          * khtml/khtml_part.cpp:
          (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.109 +9 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.1.2.108
  retrieving revision 1.1.2.109
  diff -u -r1.1.2.108 -r1.1.2.109
  --- ChangeLog	16 Dec 2005 00:17:08 -0000	1.1.2.108
  +++ ChangeLog	16 Dec 2005 20:35:37 -0000	1.1.2.109
  @@ -1,3 +1,12 @@
  +2005-12-16  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by Maciej.
  +
  +        Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()
  +
  +        * khtml/khtml_part.cpp:
  +        (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.
  +
   === WebCore-417.14 ===
   
   2005-12-14  Timothy Hatcher  <timothy at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.311.8.17 +3 -1      WebCore/khtml/khtml_part.cpp
  
  Index: khtml_part.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/khtml_part.cpp,v
  retrieving revision 1.311.8.16
  retrieving revision 1.311.8.17
  diff -u -r1.311.8.16 -r1.311.8.17
  --- khtml_part.cpp	12 Dec 2005 19:07:09 -0000	1.311.8.16
  +++ khtml_part.cpp	16 Dec 2005 20:35:47 -0000	1.311.8.17
  @@ -1785,7 +1785,9 @@
   
     if (!d->m_view)
       return; // We are probably being destructed.
  -    
  +  
  +  // Since checkCompleted can end up destroying the part, we want to make sure we're protected against getting deleted here.
  +  khtml::SharedPtr<KHTMLPart> protector(this);
     checkCompleted();
   
     if (!d->m_view)