[webkit-changes] cvs commit: WebKit/WebView.subproj WebHTMLView.m
Darin
darin at opensource.apple.com
Fri Dec 16 08:51:11 PST 2005
darin 05/12/16 08:51:11
Modified: . ChangeLog
WebView.subproj WebHTMLView.m
Log:
Reviewed and landed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4680
WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange "not yet implemented"
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]):
Implement by calling the same RTF conversion used when copying to the pasteboard.
Revision Changes Path
1.3406 +10 -0 WebKit/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebKit/ChangeLog,v
retrieving revision 1.3405
retrieving revision 1.3406
diff -u -r1.3405 -r1.3406
--- ChangeLog 16 Dec 2005 16:11:41 -0000 1.3405
+++ ChangeLog 16 Dec 2005 16:51:03 -0000 1.3406
@@ -1,3 +1,13 @@
+2005-12-16 Evan Gross <evan at rainmakerinc.com>
+
+ Reviewed and landed by Darin.
+
+ - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4680
+ WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange "not yet implemented"
+
+ * WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]):
+ Implement by calling the same RTF conversion used when copying to the pasteboard.
+
2005-12-16 Mitz Pettel <opendarwin.org at mitzpettel.com>
Reviewed and landed by Darin.
1.492 +6 -2 WebKit/WebView.subproj/WebHTMLView.m
Index: WebHTMLView.m
===================================================================
RCS file: /cvs/root/WebKit/WebView.subproj/WebHTMLView.m,v
retrieving revision 1.491
retrieving revision 1.492
diff -u -r1.491 -r1.492
--- WebHTMLView.m 13 Dec 2005 04:39:13 -0000 1.491
+++ WebHTMLView.m 16 Dec 2005 16:51:10 -0000 1.492
@@ -5021,8 +5021,12 @@
- (NSAttributedString *)attributedSubstringFromRange:(NSRange)theRange
{
- ERROR("TEXTINPUT: attributedSubstringFromRange: not yet implemented");
- return nil;
+ WebBridge *bridge = [self _bridge];
+ DOMRange *range = [bridge convertNSRangeToDOMRange:theRange];
+ if (!range)
+ return nil;
+
+ return [bridge attributedStringFrom:[range startContainer] startOffset:[range startOffset] to:[range endContainer] endOffset:[range endOffset]];
}
// test for 10.4 because of <rdar://problem/4243463>
More information about the webkit-changes
mailing list