[webkit-changes] cvs commit: WebCore/khtml/ecma domparser.cpp

[Darin]

darin       05/12/15 23:51:13

  Modified:    .        ChangeLog
               khtml/ecma domparser.cpp
  Log:
          - fix crash caused by my last check-in
  
          * khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
          Use RefPtr to ref/deref the tokenizer.
  
  Revision  Changes    Path
  1.544     +7 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.543
  retrieving revision 1.544
  diff -u -r1.543 -r1.544
  --- ChangeLog	16 Dec 2005 07:27:58 -0000	1.543
  +++ ChangeLog	16 Dec 2005 07:51:07 -0000	1.544
  @@ -1,5 +1,12 @@
   2005-12-15  Darin Adler  <darin at apple.com>
   
  +        - fix crash caused by my last check-in
  +
  +        * khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
  +        Use RefPtr to ref/deref the tokenizer.
  +
  +2005-12-15  Darin Adler  <darin at apple.com>
  +
           * khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::exitText):
           Add missing null check.
   
  
  
  
  1.11      +7 -7      WebCore/khtml/ecma/domparser.cpp
  
  Index: domparser.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/domparser.cpp,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- domparser.cpp	11 Dec 2005 02:06:04 -0000	1.10
  +++ domparser.cpp	16 Dec 2005 07:51:12 -0000	1.11
  @@ -86,18 +86,18 @@
         QString contentType = args[1]->toString(exec).qstring().stripWhiteSpace();
   
         if (DOMImplementationImpl::isXMLMIMEType(contentType)) {
  -        DocumentImpl *docImpl = parser->doc->implementation()->createDocument();
  +        RefPtr<DocumentImpl> doc = parser->doc->implementation()->createDocument();
   
  -        docImpl->open();
  -        docImpl->write(str);
  -        docImpl->finishParsing();
  -        docImpl->close();
  +        doc->open();
  +        doc->write(str);
  +        doc->finishParsing();
  +        doc->close();
   
  -        return getDOMNode(exec, docImpl);
  +        return getDOMNode(exec, doc.get());
         }
       }
     }
  -		
  +
     return jsUndefined();
   }