[webkit-changes] cvs commit: WebCore/khtml/html html_headimpl.cpp

[Darin]

darin       05/12/15 12:20:02

  Modified:    .        ChangeLog
               khtml/html html_headimpl.cpp
  Log:
          Reviewed by Tim Hatcher.
  
          - removed unnecessary conversion between AtomicString and QString
  
          * khtml/html/html_headimpl.cpp:
          (HTMLScriptElementImpl::parseMappedAttribute): Remove extra conversions.
          (HTMLScriptElementImpl::insertedIntoDocument): Ditto.
  
  Revision  Changes    Path
  1.534     +11 -1     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.533
  retrieving revision 1.534
  diff -u -r1.533 -r1.534
  --- ChangeLog	15 Dec 2005 04:29:45 -0000	1.533
  +++ ChangeLog	15 Dec 2005 20:19:59 -0000	1.534
  @@ -1,3 +1,13 @@
  +2005-12-15  Darin Adler  <darin at apple.com>
  +
  +        Reviewed by Tim Hatcher.
  +
  +        - removed unnecessary conversion between AtomicString and QString
  +
  +        * khtml/html/html_headimpl.cpp:
  +        (HTMLScriptElementImpl::parseMappedAttribute): Remove extra conversions.
  +        (HTMLScriptElementImpl::insertedIntoDocument): Ditto.
  +
   2005-12-14  Adele Peterson  <adele at apple.com>
   
           Reviewed by Darin and Tim Hatcher.
  @@ -168,7 +178,7 @@
            * khtml/rendering/render_text.cpp:
            (RenderText::positionForCoordinates): Adjust for containing block scroll
            
  -2005-12-14 Alexey Proskuryakov  <ap at nypop.com>
  +2005-12-14  Alexey Proskuryakov  <ap at nypop.com>
   
           Reviewed by Darin, committed by Adele.
   
  
  
  
  1.62      +4 -4      WebCore/khtml/html/html_headimpl.cpp
  
  Index: html_headimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_headimpl.cpp,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -r1.61 -r1.62
  --- html_headimpl.cpp	14 Dec 2005 23:31:51 -0000	1.61
  +++ html_headimpl.cpp	15 Dec 2005 20:20:01 -0000	1.62
  @@ -515,10 +515,10 @@
           if (!getDocument()->part())
               return;
       
  -        QString url = attr->value().qstring();
  +        const AtomicString& url = attr->value();
           if (!url.isEmpty()) {
               QString charset = getAttribute(charsetAttr).qstring();
  -            m_cachedScript = getDocument()->docLoader()->requestScript(DOMString(url), charset);
  +            m_cachedScript = getDocument()->docLoader()->requestScript(url, charset);
               m_cachedScript->ref(this);
           }
       } else
  @@ -548,10 +548,10 @@
       if (!getDocument()->part())
           return;
       
  -    QString url = getAttribute(srcAttr).qstring();
  +    const AtomicString& url = getAttribute(srcAttr);
       if (!url.isEmpty()) {
           QString charset = getAttribute(charsetAttr).qstring();
  -        m_cachedScript = getDocument()->docLoader()->requestScript(DOMString(url), charset);
  +        m_cachedScript = getDocument()->docLoader()->requestScript(url, charset);
           m_cachedScript->ref(this);
           return;
       }