[webkit-changes] cvs commit: WebCore/kwq KWQTextArea.mm
Beth
bdakin at opensource.apple.com
Wed Dec 14 14:39:01 PST 2005
bdakin 05/12/14 14:39:01
Modified: . ChangeLog
kwq KWQTextArea.mm
Log:
Bug #:
Revision Changes Path
1.531 +12 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.530
retrieving revision 1.531
diff -u -r1.530 -r1.531
--- ChangeLog 14 Dec 2005 22:16:15 -0000 1.530
+++ ChangeLog 14 Dec 2005 22:38:56 -0000 1.531
@@ -1,5 +1,17 @@
2005-12-14 Beth Dakin <bdakin at apple.com>
+ Reviewed by John.
+
+ Extra fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
+ disappears when typing at the bottom of a scrollable textarea.
+
+ Should be floorf and not floor.
+
+ * kwq/KWQTextArea.mm:
+ (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]):
+
+2005-12-14 Beth Dakin <bdakin at apple.com>
+
Reviewed by Eric.
Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
1.99 +1 -1 WebCore/kwq/KWQTextArea.mm
Index: KWQTextArea.mm
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQTextArea.mm,v
retrieving revision 1.98
retrieving revision 1.99
diff -u -r1.98 -r1.99
--- KWQTextArea.mm 14 Dec 2005 22:16:17 -0000 1.98
+++ KWQTextArea.mm 14 Dec 2005 22:39:00 -0000 1.99
@@ -1293,7 +1293,7 @@
NSMutableDictionary *dict;
float fontHeight = [[self layoutManager] defaultLineHeightForFont:font];
float h = (lineHeight / 2.0f) - (fontHeight / 2.0f);
- h = (h >= 0.0) ? floor(h) : -floor(-h);
+ h = (h >= 0.0) ? floorf(h) : -floorf(-h);
if (typingAttrs)
dict = [typingAttrs mutableCopy];
More information about the webkit-changes
mailing list