[webkit-changes] cvs commit: LayoutTests/fast/forms
checkbox-radio-onchange-expected.checksum
checkbox-radio-onchange-expected.png
checkbox-radio-onchange-expected.txt checkbox-radio-onchange.html
Adele
adele at opensource.apple.com
Tue Dec 13 23:48:42 PST 2005
adele 05/12/13 23:48:42
Modified: . ChangeLog
khtml/html html_formimpl.cpp
. ChangeLog
Added: fast/forms checkbox-radio-onchange-expected.checksum
checkbox-radio-onchange-expected.png
checkbox-radio-onchange-expected.txt
checkbox-radio-onchange.html
Log:
LayoutTests:
Reviewed by Maciej.
Test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)
* fast/forms/checkbox-radio-onchange-expected.checksum: Added.
* fast/forms/checkbox-radio-onchange-expected.png: Added.
* fast/forms/checkbox-radio-onchange-expected.txt: Added.
* fast/forms/checkbox-radio-onchange.html: Added.
WebCore:
Reviewed by Maciej.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)
Test: fast/forms/checkbox-radio-onchange.html
* khtml/html/html_formimpl.cpp:
(DOM::HTMLInputElementImpl::setChecked): call onChange after setting the checked state.
This will match our old behavior, and Firefox behavior.
This will also fire onChange for radio buttons which matches Firefox behavior.
Revision Changes Path
1.527 +14 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.526
retrieving revision 1.527
diff -u -r1.526 -r1.527
--- ChangeLog 14 Dec 2005 02:21:58 -0000 1.526
+++ ChangeLog 14 Dec 2005 07:48:35 -0000 1.527
@@ -1,3 +1,17 @@
+2005-12-13 Adele Peterson <adele at apple.com>
+
+ Reviewed by Maciej.
+
+ Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
+ REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)
+
+ Test: fast/forms/checkbox-radio-onchange.html
+
+ * khtml/html/html_formimpl.cpp:
+ (DOM::HTMLInputElementImpl::setChecked): call onChange after setting the checked state.
+ This will match our old behavior, and Firefox behavior.
+ This will also fire onChange for radio buttons which matches Firefox behavior.
+
2005-12-13 Beth Dakin <bdakin at apple.com>
Reviewed by Hyatt and Darin.
1.208 +2 -1 WebCore/khtml/html/html_formimpl.cpp
Index: html_formimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
retrieving revision 1.207
retrieving revision 1.208
diff -u -r1.207 -r1.208
--- html_formimpl.cpp 12 Dec 2005 19:22:15 -0000 1.207
+++ html_formimpl.cpp 14 Dec 2005 07:48:39 -0000 1.208
@@ -4,7 +4,7 @@
* Copyright (C) 1999 Lars Knoll (knoll at kde.org)
* (C) 1999 Antti Koivisto (koivisto at kde.org)
* (C) 2001 Dirk Mueller (mueller at kde.org)
- * Copyright (C) 2004 Apple Computer, Inc.
+ * Copyright (C) 2004, 2005 Apple Computer, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -1967,6 +1967,7 @@
setChanged();
if (renderer() && renderer()->style()->hasAppearance())
theme()->stateChanged(renderer(), CheckedState);
+ onChange();
}
void HTMLInputElementImpl::setIndeterminate(bool _indeterminate)
1.151 +12 -0 LayoutTests/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/LayoutTests/ChangeLog,v
retrieving revision 1.150
retrieving revision 1.151
diff -u -r1.150 -r1.151
--- ChangeLog 14 Dec 2005 00:40:51 -0000 1.150
+++ ChangeLog 14 Dec 2005 07:48:40 -0000 1.151
@@ -1,3 +1,15 @@
+2005-12-13 Adele Peterson <adele at apple.com>
+
+ Reviewed by Maciej.
+
+ Test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
+ REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)
+
+ * fast/forms/checkbox-radio-onchange-expected.checksum: Added.
+ * fast/forms/checkbox-radio-onchange-expected.png: Added.
+ * fast/forms/checkbox-radio-onchange-expected.txt: Added.
+ * fast/forms/checkbox-radio-onchange.html: Added.
+
2005-12-13 Timothy Hatcher <timothy at apple.com>
Reviewed by Hyatt.
1.1 LayoutTests/fast/forms/checkbox-radio-onchange-expected.checksum
Index: checkbox-radio-onchange-expected.checksum
===================================================================
09578fd311a8d4c6cdc07164cc376746
1.1 LayoutTests/fast/forms/checkbox-radio-onchange-expected.png
<<Binary file>>
1.1 LayoutTests/fast/forms/checkbox-radio-onchange-expected.txt
Index: checkbox-radio-onchange-expected.txt
===================================================================
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock (anonymous) at (0,0) size 784x37
RenderText {TEXT} at (0,0) size 364x18
text run at (0,0) width 364: "This is to test onchange of checkboxes and radio buttons. "
RenderBR {BR} at (0,0) size 0x0
RenderBlock {INPUT} at (3,22) size 12x12
RenderText {TEXT} at (18,18) size 65x18
text run at (18,18) width 65: "Checkbox"
RenderText {TEXT} at (0,0) size 0x0
RenderBlock {DIV} at (0,37) size 784x18
RenderText {TEXT} at (0,0) size 321x18
text run at (0,0) width 321: "Test 1 Passed. onChange event fired for checkbox."
RenderBlock (anonymous) at (0,55) size 784x19
RenderBlock {INPUT} at (3,3) size 12x13
RenderText {TEXT} at (18,0) size 50x18
text run at (18,0) width 50: "Radio 1"
RenderText {TEXT} at (68,0) size 4x18
text run at (68,0) width 4: " "
RenderBlock {INPUT} at (75,3) size 12x13
RenderText {TEXT} at (90,0) size 50x18
text run at (90,0) width 50: "Radio 2"
RenderText {TEXT} at (0,0) size 0x0
RenderBlock {DIV} at (0,74) size 784x18
RenderText {TEXT} at (0,0) size 336x18
text run at (0,0) width 336: "Test 2 Passed. onChange event fired for radio button."
1.1 LayoutTests/fast/forms/checkbox-radio-onchange.html
Index: checkbox-radio-onchange.html
===================================================================
<html>
<body onload="document.getElementById('ch').click(); document.getElementById('rd2').click()">
This is to test onchange of checkboxes and radio buttons.
<br>
<input type="checkbox" id="ch" onchange="document.getElementById('result').innerHTML = 'Test 1 Passed. onChange event fired for checkbox.\n'">Checkbox</input>
<div id="result">Test 1 Failed. onChange didn't fire.</div>
<input type="radio" id="rd" name="test">Radio 1</input>
<input type="radio" id="rd2" name="test" onchange="document.getElementById('result2').innerHTML = 'Test 2 Passed. onChange event fired for radio button.\n'">Radio 2</input>
<div id="result2">Test 2 Failed. onChange didn't fire.</div>
</body>
</html>
More information about the webkit-changes
mailing list