[webkit-changes] cvs commit: WebCore/khtml/editing visible_units.cpp

[Justin]

justing     05/12/12 17:50:27

  Modified:    .        ChangeLog
               khtml/editing visible_units.cpp
  Log:
          Reviewed by harrison
  
          <rdar://problem/4040763> VisiblePosition constructor can return a result outside of the original
  
          This bug was filed as a reminder to remove the workaround for
          <rdar://problem/4033202>.  We fixed the problems with
          VisiblePosition causing 4033202, so I removed the workaround
          and added a layout test.
  
          * khtml/editing/visible_units.cpp:
          (khtml::previousLinePosition):
  
  Revision  Changes    Path
  1.518     +14 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.517
  retrieving revision 1.518
  diff -u -r1.517 -r1.518
  --- ChangeLog	13 Dec 2005 01:28:50 -0000	1.517
  +++ ChangeLog	13 Dec 2005 01:50:22 -0000	1.518
  @@ -1,3 +1,17 @@
  +2005-12-12  Justin Garcia  <justin.garcia at apple.com>
  +
  +        Reviewed by harrison
  +        
  +        <rdar://problem/4040763> VisiblePosition constructor can return a result outside of the original 
  +
  +        This bug was filed as a reminder to remove the workaround for 
  +        <rdar://problem/4033202>.  We fixed the problems with 
  +        VisiblePosition causing 4033202, so I removed the workaround 
  +        and added a layout test.
  +
  +        * khtml/editing/visible_units.cpp:
  +        (khtml::previousLinePosition):
  +
   2005-12-12  David Harrison  <harrison at apple.com>
   
           Reviewed by Justin.
  
  
  
  1.46      +1 -8      WebCore/khtml/editing/visible_units.cpp
  
  Index: visible_units.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/editing/visible_units.cpp,v
  retrieving revision 1.45
  retrieving revision 1.46
  diff -u -r1.45 -r1.46
  --- visible_units.cpp	10 Dec 2005 02:59:31 -0000	1.45
  +++ visible_units.cpp	13 Dec 2005 01:50:27 -0000	1.46
  @@ -403,14 +403,7 @@
                       break;
                   }
   
  -                // Work around <rdar://problem/4040763>.  Need to
  -                // doublecheck that pos is really on a different line,
  -                // because it might not be a viable VisiblePosition
  -                // (whereupon the next VP is returned, which could be
  -                // back on c's line)
  -                VisiblePosition c2 = VisiblePosition(pos, DOWNSTREAM);
  -                if (!inSameLine(c, c2))
  -                    return c2;
  +                return VisiblePosition(pos, DOWNSTREAM);
               }
               n = n->previousEditable();
           }