[webkit-changes] cvs commit: WebCore/kwq KWQScrollView.mm

[Timothy]

thatcher    05/12/12 15:54:05

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               kwq      Tag: Safari-1-3-branch KWQScrollView.mm
  Log:
          Merged fix from TOT to Safari-1-3-branch
  
      2005-12-09  Tim Omernick  <timo at apple.com>
  
          Reviewed by Darin.
  
          <rdar://problem/4371187> Regression: Anchor tags for navigation
          within messages in HTML mail no longer working
  
          A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
          Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().
  
          * kwq/KWQScrollView.mm:
          (QScrollView::setContentsPos):
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.335.2.51 +17 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.335.2.50
  retrieving revision 1.335.2.51
  diff -u -r1.335.2.50 -r1.335.2.51
  --- ChangeLog	12 Dec 2005 23:49:43 -0000	1.335.2.50
  +++ ChangeLog	12 Dec 2005 23:53:57 -0000	1.335.2.51
  @@ -2,6 +2,23 @@
   
           Merged fix from TOT to Safari-1-3-branch
   
  +    2005-12-09  Tim Omernick  <timo at apple.com>
  +
  +        Reviewed by Darin.
  +
  +        <rdar://problem/4371187> Regression: Anchor tags for navigation
  +        within messages in HTML mail no longer working
  +    
  +        A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
  +        Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().
  +
  +        * kwq/KWQScrollView.mm:
  +        (QScrollView::setContentsPos):
  +
  +2005-12-12  Timothy Hatcher  <timothy at apple.com>
  +
  +        Merged fix from TOT to Safari-1-3-branch
  +
       2005-12-12  Eric Seidel  <eseidel at apple.com>
   
           Reviewed by ggaren.
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.80.6.2  +9 -1      WebCore/kwq/KWQScrollView.mm
  
  Index: KWQScrollView.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQScrollView.mm,v
  retrieving revision 1.80.6.1
  retrieving revision 1.80.6.2
  diff -u -r1.80.6.1 -r1.80.6.2
  --- KWQScrollView.mm	12 Nov 2005 01:57:44 -0000	1.80.6.1
  +++ KWQScrollView.mm	12 Dec 2005 23:54:05 -0000	1.80.6.2
  @@ -184,7 +184,15 @@
       if (docView)
           view = docView;
           
  -    [view scrollPoint:p];
  +    NSView *originalView = view;
  +    while (view) {
  +        if ([view isKindOfClass:[NSClipView class]]) {
  +            NSPoint viewPoint = [view convertPoint:p fromView:originalView];
  +            [view scrollRectToVisible:NSMakeRect(viewPoint.x, viewPoint.y, 1, NSHeight([view bounds]))];
  +        }
  +        view = [view superview];
  +    }
  +
       KWQ_UNBLOCK_EXCEPTIONS;
   }