[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp

[Eric]

eseidel     05/12/12 11:22:16

  Modified:    .        ChangeLog
               khtml/html html_formimpl.cpp
  Log:
  Bug #: 4372143
  Submitted by: eseidel
  Reviewed by: ggaren
          Test: fast/forms/textarea-setinnerhtml.html
  
          Fixes setInnerHTML for <textarea>
          <rdar://problem/4372143>
  
          * khtml/html/html_formimpl.cpp:
          (DOM::HTMLTextAreaElementImpl::setValue):
  
  Revision  Changes    Path
  1.515     +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.514
  retrieving revision 1.515
  diff -u -r1.514 -r1.515
  --- ChangeLog	12 Dec 2005 19:04:25 -0000	1.514
  +++ ChangeLog	12 Dec 2005 19:22:11 -0000	1.515
  @@ -1,3 +1,15 @@
  +2005-12-12  Eric Seidel  <eseidel at apple.com>
  +
  +        Reviewed by ggaren.
  +
  +        Test: fast/forms/textarea-setinnerhtml.html
  +
  +        Fixes setInnerHTML for <textarea>
  +        <rdar://problem/4372143>
  +
  +        * khtml/html/html_formimpl.cpp:
  +        (DOM::HTMLTextAreaElementImpl::setValue):
  +
   2005-12-12  Adele Peterson  <adele at apple.com>
   
           Reviewed by Dave Harrison.
  
  
  
  1.207     +3 -1      WebCore/khtml/html/html_formimpl.cpp
  
  Index: html_formimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
  retrieving revision 1.206
  retrieving revision 1.207
  diff -u -r1.206 -r1.207
  --- html_formimpl.cpp	1 Dec 2005 10:32:18 -0000	1.206
  +++ html_formimpl.cpp	12 Dec 2005 19:22:15 -0000	1.207
  @@ -3484,9 +3484,11 @@
   {
       m_value = value.qstring();
       m_valueMatchesRenderer = false;
  +    m_valueIsValid = true;
       if (m_render)
           m_render->updateFromElement();
  -    m_valueIsValid = false; // force the next access to fetch from the renderer
  +    // FIXME: Force reload from renderer, as renderer may have normalized line endings.
  +    m_valueIsValid = false;
       setChanged(true);
   }