[webkit-changes] cvs commit: WebKit/WebView.subproj WebView.m

John sullivan at opensource.apple.com
Fri Dec 9 20:52:04 PST 2005


sullivan    05/12/09 20:52:04

  Modified:    .        ChangeLog
               WebView.subproj WebView.m
  Log:
          Reviewed by Adele Peterson.
  
          - fixed <rdar://problem/4373905> Cannot paste in Tiger Mail using TOT WebKit
  
          * WebView.subproj/WebView.m:
          (-[WebView _frameForCurrentSelection]):
          I removed this method many moons ago when restructuring the code involving frames and selection.
          Too bad Mail was still using it (d'oh!). In Leopard Mail has updated to use newer SPI (which should
          become API), but to continue to work with Mail on Tiger we need this method to be around. Now it's
          just a cover for the method _selectedOrMainFrame, to which it was renamed so very long ago.
  
  Revision  Changes    Path
  1.3395    +13 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3394
  retrieving revision 1.3395
  diff -u -r1.3394 -r1.3395
  --- ChangeLog	10 Dec 2005 02:13:02 -0000	1.3394
  +++ ChangeLog	10 Dec 2005 04:51:55 -0000	1.3395
  @@ -1,3 +1,16 @@
  +2005-12-09  John Sullivan  <sullivan at apple.com>
  +
  +        Reviewed by Adele Peterson.
  +        
  +        - fixed <rdar://problem/4373905> Cannot paste in Tiger Mail using TOT WebKit
  +
  +        * WebView.subproj/WebView.m:
  +        (-[WebView _frameForCurrentSelection]):
  +        I removed this method many moons ago when restructuring the code involving frames and selection.
  +        Too bad Mail was still using it (d'oh!). In Leopard Mail has updated to use newer SPI (which should
  +        become API), but to continue to work with Mail on Tiger we need this method to be around. Now it's
  +        just a cover for the method _selectedOrMainFrame, to which it was renamed so very long ago.
  +
   2005-12-09  Tim Omernick  <timo at apple.com>
   
           Reviewed by John Sullivan.
  
  
  
  1.315     +7 -0      WebKit/WebView.subproj/WebView.m
  
  Index: WebView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebView.m,v
  retrieving revision 1.314
  retrieving revision 1.315
  diff -u -r1.314 -r1.315
  --- WebView.m	8 Dec 2005 18:33:56 -0000	1.314
  +++ WebView.m	10 Dec 2005 04:52:03 -0000	1.315
  @@ -2554,6 +2554,13 @@
       return [self isEditable];
   }
   
  +// This method name is used by Mail on Tiger (but not post-Tiger), so we shouldn't delete it 
  +// until the day comes when we're no longer supporting Mail on Tiger.
  +- (WebFrame *)_frameForCurrentSelection
  +{
  +    return [self _selectedOrMainFrame];
  +}
  +
   - (WebFrame *)selectedFrame
   {
       // If the first responder is a view in our tree, we get the frame containing the first responder.
  
  
  



More information about the webkit-changes mailing list