[webkit-changes] cvs commit: WebCore/kwq KWQScrollView.mm

[David]

harrison    05/12/09 15:48:58

  Modified:    .        ChangeLog
               kwq      KWQScrollView.mm
  Log:
          Reviewed by Darin.
  
  	<rdar://problem/4371187> 10.4.4 Regression: Anchor tags for navigation
  	within messages in HTML mail no longer working
  
  	A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
  	Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().
  
          * kwq/KWQScrollView.mm:
          (QScrollView::setContentsPos):
  
  Revision  Changes    Path
  1.496     +13 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.495
  retrieving revision 1.496
  diff -u -r1.495 -r1.496
  --- ChangeLog	9 Dec 2005 02:09:57 -0000	1.495
  +++ ChangeLog	9 Dec 2005 23:48:53 -0000	1.496
  @@ -1,3 +1,16 @@
  +2005-12-09  Tim Omernick  <timo at apple.com>
  +
  +        Reviewed by Darin.
  +
  +	<rdar://problem/4371187> 10.4.4 Regression: Anchor tags for navigation
  +	within messages in HTML mail no longer working
  +
  +	A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
  +	Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().
  +
  +        * kwq/KWQScrollView.mm:
  +        (QScrollView::setContentsPos):
  +
   2005-12-08  Tim Omernick  <timo at apple.com>
   
           Reviewed by Maciej.
  
  
  
  1.87      +9 -1      WebCore/kwq/KWQScrollView.mm
  
  Index: KWQScrollView.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQScrollView.mm,v
  retrieving revision 1.86
  retrieving revision 1.87
  diff -u -r1.86 -r1.87
  --- KWQScrollView.mm	3 Nov 2005 19:12:07 -0000	1.86
  +++ KWQScrollView.mm	9 Dec 2005 23:48:57 -0000	1.87
  @@ -183,7 +183,15 @@
       if (docView)
           view = docView;
           
  -    [view scrollPoint:p];
  +    NSView *originalView = view;
  +    while (view) {
  +        if ([view isKindOfClass:[NSClipView class]]) {
  +            NSPoint viewPoint = [view convertPoint:p fromView:originalView];
  +            [view scrollRectToVisible:NSMakeRect(viewPoint.x, viewPoint.y, 1, NSHeight([view bounds]))];
  +        }
  +        view = [view superview];
  +    }
  +
       KWQ_UNBLOCK_EXCEPTIONS;
   }