[webkit-changes] cvs commit: WebKit/WebView.subproj WebPDFView.m

[John]

sullivan    05/12/08 16:06:45

  Modified:    .        ChangeLog
               WebView.subproj WebPDFView.m
  Log:
          Reviewed by Tim Omernick and Dave Hyatt.
  
          - fixed these semi-legendary bugs:
          <rdar://problem/4032405> Inline PDF doesn't get keyboard focus like web pages do, so can't scroll with keys without clicking
          <rdar://problem/4265684> PDFs use secondary selection when displaying found text (4748)
  
          * WebView.subproj/WebPDFView.m:
          (-[WebPDFView becomeFirstResponder]):
          Discovered that there is indeed PDFKit API for accessing the view that becomes focused; now
          passes the focus down to that view.
  
  Revision  Changes    Path
  1.3391    +14 -1     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3390
  retrieving revision 1.3391
  diff -u -r1.3390 -r1.3391
  --- ChangeLog	8 Dec 2005 19:44:08 -0000	1.3390
  +++ ChangeLog	9 Dec 2005 00:06:36 -0000	1.3391
  @@ -1,6 +1,19 @@
   2005-12-08  John Sullivan  <sullivan at apple.com>
   
  -        Reviewed by Tim O.
  +        Reviewed by Tim Omernick and Dave Hyatt.
  +        
  +        - fixed these semi-legendary bugs:
  +        <rdar://problem/4032405> Inline PDF doesn't get keyboard focus like web pages do, so can't scroll with keys without clicking
  +        <rdar://problem/4265684> PDFs use secondary selection when displaying found text (4748)
  +
  +        * WebView.subproj/WebPDFView.m:
  +        (-[WebPDFView becomeFirstResponder]):
  +        Discovered that there is indeed PDFKit API for accessing the view that becomes focused; now
  +        passes the focus down to that view.
  +
  +2005-12-08  John Sullivan  <sullivan at apple.com>
  +
  +        Reviewed by Tim Omernick.
           
           - Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy,
           in order to start addressing keyboard focus and selection highlight issues. Unfortunately this 
  
  
  
  1.30      +4 -5      WebKit/WebView.subproj/WebPDFView.m
  
  Index: WebPDFView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebPDFView.m,v
  retrieving revision 1.29
  retrieving revision 1.30
  diff -u -r1.29 -r1.30
  --- WebPDFView.m	8 Dec 2005 19:44:15 -0000	1.29
  +++ WebPDFView.m	9 Dec 2005 00:06:45 -0000	1.30
  @@ -751,11 +751,10 @@
           if ((previousValidKeyView != self) && (previousValidKeyView != PDFSubview))
               newFirstResponder = previousValidKeyView;
       } else {
  -        // FIXME 4370845: Passing first responder-ness down to the PDFSubview itself
  -        // should work, but doesn't due to missing first responder-passing code needed
  -        // in PDFKit. So this next line doesn't currently help (or hurt), but it should start
  -        // working when PDFKit fixes 4370845.
  -        newFirstResponder = PDFSubview;
  +        NSView *PDFDocumentView = [PDFSubview documentView];
  +        if ([PDFDocumentView acceptsFirstResponder]) {
  +            newFirstResponder = PDFDocumentView;
  +        }
       }
       
       if (!newFirstResponder)