[webkit-changes] cvs commit: WebKit/WebView.subproj WebHTMLView.m

[John]

sullivan    05/12/07 16:19:21

  Modified:    .        ChangeLog
               WebView.subproj WebHTMLView.m
  Log:
          Reviewed by Tim Omernick.
  
          - <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView]
          @ home.netscape.com
  
          * WebView.subproj/WebHTMLView.m:
          (-[NSArray nextValidKeyView]):
          Removed assert that I added a while back. In this case at least, the assertion is
          overzealous, and I can't recreate the tortured chain of logic that led me to adding
          this assertion in the first place.
  
  Revision  Changes    Path
  1.3386    +13 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3385
  retrieving revision 1.3386
  diff -u -r1.3385 -r1.3386
  --- ChangeLog	6 Dec 2005 22:12:00 -0000	1.3385
  +++ ChangeLog	8 Dec 2005 00:19:13 -0000	1.3386
  @@ -1,3 +1,16 @@
  +2005-12-07  John Sullivan  <sullivan at apple.com>
  +
  +        Reviewed by Tim Omernick.
  +        
  +        - <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView] 
  +        @ home.netscape.com
  +
  +        * WebView.subproj/WebHTMLView.m:
  +        (-[NSArray nextValidKeyView]):
  +        Removed assert that I added a while back. In this case at least, the assertion is
  +        overzealous, and I can't recreate the tortured chain of logic that led me to adding
  +        this assertion in the first place.
  +
   2005-12-06  David Harrison  <harrison at apple.com>
   
   	Reviewed by Darin.
  
  
  
  1.487     +0 -1      WebKit/WebView.subproj/WebHTMLView.m
  
  Index: WebHTMLView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebHTMLView.m,v
  retrieving revision 1.486
  retrieving revision 1.487
  diff -u -r1.486 -r1.487
  --- WebHTMLView.m	6 Dec 2005 22:12:07 -0000	1.486
  +++ WebHTMLView.m	8 Dec 2005 00:19:20 -0000	1.487
  @@ -2936,7 +2936,6 @@
           // WebFrameView has this same kind of logic for the previousValidKeyView case.
           if (view == nil || view == self) {
               ASSERT([self _frame] != [[self _webView] mainFrame]);
  -            ASSERT(lookInsideWebFrameViews);
               view = [[self _bridge] nextValidKeyViewOutsideWebFrameViews];
           }
       }