[webkit-changes] cvs commit: WebKit/WebView.subproj WebHTMLView.m

[David]

harrison    05/12/06 14:12:08

  Modified:    .        ChangeLog
               WebView.subproj WebHTMLView.m
  Log:
  	Reviewed by Darin.
  
  	- fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields
  
  	Add use of NSAccessibilityHitTest to the list of exceptions.
  
  	* WebView.subproj/WebHTMLView.m:
  	(-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
  
  Revision  Changes    Path
  1.3385    +11 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3384
  retrieving revision 1.3385
  diff -u -r1.3384 -r1.3385
  --- ChangeLog	6 Dec 2005 01:46:29 -0000	1.3384
  +++ ChangeLog	6 Dec 2005 22:12:00 -0000	1.3385
  @@ -1,3 +1,14 @@
  +2005-12-06  David Harrison  <harrison at apple.com>
  +
  +	Reviewed by Darin.
  +
  +	- fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields
  +	
  +	Add use of NSAccessibilityHitTest to the list of exceptions.
  +
  +	* WebView.subproj/WebHTMLView.m:
  +	(-[WebHTMLView hitTest:]): check for NSFlagsChanged event. 
  +
   2005-12-05  John Sullivan  <sullivan at apple.com>
   
           Reviewed by Darin Adler.
  
  
  
  1.486     +7 -1      WebKit/WebView.subproj/WebHTMLView.m
  
  Index: WebHTMLView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebHTMLView.m,v
  retrieving revision 1.485
  retrieving revision 1.486
  diff -u -r1.485 -r1.486
  --- WebHTMLView.m	6 Dec 2005 01:46:39 -0000	1.485
  +++ WebHTMLView.m	6 Dec 2005 22:12:07 -0000	1.486
  @@ -877,6 +877,11 @@
       //      right view. The global is forceNSViewHitTest and the method they use to
       //      do the hit testing is _hitViewForEvent:. (But this does not work correctly
       //      when there is HTML overlapping the view, see bug 4361626)
  +    //   4) NSAccessibilityHitTest relies on this for checking the cursor position.
  +    //      Our check for that is whether the event is NSFlagsChanged.  This works
  +    //      for VoiceOver's cntl-opt-f5 command (move focus to item under cursor)
  +    //      and Dictionary's cmd-cntl-D (open dictionary popup for item under cursor).
  +    //      This is of course a hack.
   
       BOOL captureHitsOnSubviews;
       if (forceNSViewHitTest)
  @@ -887,7 +892,8 @@
           NSEvent *event = [[self window] currentEvent];
           captureHitsOnSubviews = !([event type] == NSMouseMoved
               || [event type] == NSRightMouseDown
  -            || ([event type] == NSLeftMouseDown && ([event modifierFlags] & NSControlKeyMask) != 0));
  +            || ([event type] == NSLeftMouseDown && ([event modifierFlags] & NSControlKeyMask) != 0)
  +	    || [event type] == NSFlagsChanged);
       }
   
       if (!captureHitsOnSubviews)