[webkit-changes] cvs commit: WebKit/WebView.subproj WebHTMLView.m
John
sullivan at opensource.apple.com
Mon Dec 5 17:46:41 PST 2005
sullivan 05/12/05 17:46:40
Modified: . ChangeLog
WebView.subproj WebHTMLView.m
Log:
Reviewed by Darin Adler.
* WebView.subproj/WebHTMLView.m:
(-[NSArray validateUserInterfaceItem:]):
one more tweak: moved jumpToSelection: to be validated the same way as
centerSelectionInVisibleArea:, since it now calls the same code. Might not
make a difference in any real code, but you never know.
Revision Changes Path
1.3384 +10 -0 WebKit/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebKit/ChangeLog,v
retrieving revision 1.3383
retrieving revision 1.3384
diff -u -r1.3383 -r1.3384
--- ChangeLog 6 Dec 2005 00:14:02 -0000 1.3383
+++ ChangeLog 6 Dec 2005 01:46:29 -0000 1.3384
@@ -4,6 +4,16 @@
* WebView.subproj/WebHTMLView.m:
(-[NSArray validateUserInterfaceItem:]):
+ one more tweak: moved jumpToSelection: to be validated the same way as
+ centerSelectionInVisibleArea:, since it now calls the same code. Might not
+ make a difference in any real code, but you never know.
+
+2005-12-05 John Sullivan <sullivan at apple.com>
+
+ Reviewed by Darin Adler.
+
+ * WebView.subproj/WebHTMLView.m:
+ (-[NSArray validateUserInterfaceItem:]):
removed double handling of centerSelectionInVisibleArea
2005-12-05 John Sullivan <sullivan at apple.com>
1.485 +1 -1 WebKit/WebView.subproj/WebHTMLView.m
Index: WebHTMLView.m
===================================================================
RCS file: /cvs/root/WebKit/WebView.subproj/WebHTMLView.m,v
retrieving revision 1.484
retrieving revision 1.485
diff -u -r1.484 -r1.485
--- WebHTMLView.m 6 Dec 2005 00:14:08 -0000 1.484
+++ WebHTMLView.m 6 Dec 2005 01:46:39 -0000 1.485
@@ -1916,6 +1916,7 @@
|| action == @selector(uppercaseWord:)) {
return [self _hasSelection] && [self _isEditable];
} else if (action == @selector(centerSelectionInVisibleArea:)
+ || action == @selector(jumpToSelection:)
|| action == @selector(copyFont:)
|| action == @selector(setMark:)) {
return [self _hasSelectionOrInsertionPoint];
@@ -1928,7 +1929,6 @@
} else if (action == @selector(delete:)) {
return [self _canDelete];
} else if (action == @selector(_ignoreSpellingFromMenu:)
- || action == @selector(jumpToSelection:)
|| action == @selector(_learnSpellingFromMenu:)
|| action == @selector(takeFindStringFromSelection:)) {
return [self _hasSelection];
More information about the webkit-changes
mailing list