[webkit-changes] cvs commit: WebCore/kwq KWQTimer.h KWQTimer.mm
John
sullivan at opensource.apple.com
Mon Dec 5 14:19:11 PST 2005
sullivan 05/12/05 14:19:11
Modified: . ChangeLog
kwq KWQTimer.h KWQTimer.mm
Log:
Reviewed by Tim Omernick.
Removed some dead code I happened to stumble across. No test cases added.
* kwq/KWQTimer.h:
removed unused immediateSingleShotOnMainThread()
* kwq/KWQTimer.mm:
removed unused immediateSingleShotOnMainThread() and the class KWQMainThreadPerformTarget
that was used to implement it.
Revision Changes Path
1.475 +12 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.474
retrieving revision 1.475
diff -u -r1.474 -r1.475
--- ChangeLog 5 Dec 2005 22:01:22 -0000 1.474
+++ ChangeLog 5 Dec 2005 22:19:09 -0000 1.475
@@ -1,6 +1,18 @@
2005-12-05 John Sullivan <sullivan at apple.com>
Reviewed by Tim Omernick.
+
+ Removed some dead code I happened to stumble across. No test cases added.
+
+ * kwq/KWQTimer.h:
+ removed unused immediateSingleShotOnMainThread()
+ * kwq/KWQTimer.mm:
+ removed unused immediateSingleShotOnMainThread() and the class KWQMainThreadPerformTarget
+ that was used to implement it.
+
+2005-12-05 John Sullivan <sullivan at apple.com>
+
+ Reviewed by Tim Omernick.
- WebCore part of fix for
<rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)
1.15 +0 -2 WebCore/kwq/KWQTimer.h
Index: KWQTimer.h
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQTimer.h,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- KWQTimer.h 9 Nov 2005 02:46:29 -0000 1.14
+++ KWQTimer.h 5 Dec 2005 22:19:10 -0000 1.15
@@ -47,8 +47,6 @@
static void singleShot(int msec, QObject *receiver, const char *member);
- static void immediateSingleShotOnMainThread(void (*func)());
-
// This is just a hack used by KWQKHTMLPart. The monitor function
// gets called when the timer starts and when it is stopped before firing,
// but not when the timer fires.
1.22 +0 -30 WebCore/kwq/KWQTimer.mm
Index: KWQTimer.mm
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQTimer.mm,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- KWQTimer.mm 9 Nov 2005 02:46:29 -0000 1.21
+++ KWQTimer.mm 5 Dec 2005 22:19:10 -0000 1.22
@@ -162,33 +162,3 @@
repeats:NO];
}
- at interface KWQMainThreadPerformTarget : NSObject
-{
- void (*_func)();
-}
-
-- (id)initWithFunction:(void (*)())func;
-- (void)callFunction:(id)ignore;
- at end
-
- at implementation KWQMainThreadPerformTarget
-- (id)initWithFunction:(void (*)())func
-{
- if ((self = [super init])) {
- _func = func;
- }
- return self;
-}
-
-- (void)callFunction:(id)ignore
-{
- _func();
-}
-
- at end
-
-void QTimer::immediateSingleShotOnMainThread(void (*func)())
-{
- [[[KWQMainThreadPerformTarget alloc] initWithFunction:func] performSelectorOnMainThread:@selector(callFunction) withObject:nil waitUntilDone:NO];
-}
-
More information about the webkit-changes
mailing list