[webkit-changes] cvs commit: WebCore/kwq KWQKPartsBrowserExtension.h
Geoffrey
ggaren at opensource.apple.com
Sat Dec 3 16:32:35 PST 2005
ggaren 05/12/03 16:32:35
Modified: . ChangeLog
khtml/ecma kjs_window.cpp
kwq KWQKPartsBrowserExtension.h
Log:
Reviewed by Kevin.
Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
show up wrong size (with scroll bars)
We had the wrong default features for new windows. The IE rule is:
all features except for channelmode and fullscreen default to YES, but
if the user specifies a feature string, all features default to NO.
(There is no public standard that applies to this method.)
<http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>
No test case because testing requires a call to window.open, which
DumpRenderTree can't simulate.
* khtml/ecma/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction):
* kwq/KWQKPartsBrowserExtension.h:
(KParts::WindowArgs::WindowArgs):
Revision Changes Path
1.465 +22 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.464
retrieving revision 1.465
diff -u -r1.464 -r1.465
--- ChangeLog 3 Dec 2005 20:16:28 -0000 1.464
+++ ChangeLog 4 Dec 2005 00:32:32 -0000 1.465
@@ -1,3 +1,25 @@
+2005-12-03 Geoffrey Garen <ggaren at apple.com>
+
+ Reviewed by Kevin.
+
+ Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
+ show up wrong size (with scroll bars)
+
+ We had the wrong default features for new windows. The IE rule is:
+ all features except for channelmode and fullscreen default to YES, but
+ if the user specifies a feature string, all features default to NO.
+ (There is no public standard that applies to this method.)
+
+ <http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>
+
+ No test case because testing requires a call to window.open, which
+ DumpRenderTree can't simulate.
+
+ * khtml/ecma/kjs_window.cpp:
+ (KJS::WindowFunc::callAsFunction):
+ * kwq/KWQKPartsBrowserExtension.h:
+ (KParts::WindowArgs::WindowArgs):
+
2005-12-01 Anders Carlsson <andersca at mac.com>
Reviewed by Darin.
1.193 +5 -7 WebCore/khtml/ecma/kjs_window.cpp
Index: kjs_window.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/ecma/kjs_window.cpp,v
retrieving revision 1.192
retrieving revision 1.193
diff -u -r1.192 -r1.193
--- kjs_window.cpp 2 Dec 2005 20:58:02 -0000 1.192
+++ kjs_window.cpp 4 Dec 2005 00:32:34 -0000 1.193
@@ -1541,16 +1541,14 @@
KParts::WindowArgs winargs;
- // scan feature argument
- v = args[2];
- QString features;
- if (!v->isUndefinedOrNull() && v->toString(exec).size() > 0) {
- features = v->toString(exec).qstring();
- // specifying window params means false defaults
+ QString features = args[2]->toString(exec).qstring();
+ if (features.length() > 0) {
+ // when features is specified, all features default to false
winargs.menuBarVisible = false;
winargs.toolBarsVisible = false;
winargs.statusBarVisible = false;
- winargs.scrollbarsVisible = true;
+ winargs.scrollbarsVisible = false;
+ winargs.resizable = false;
QStringList flist = QStringList::split(',', features);
QStringList::ConstIterator it = flist.begin();
while (it != flist.end()) {
1.27 +1 -1 WebCore/kwq/KWQKPartsBrowserExtension.h
Index: KWQKPartsBrowserExtension.h
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQKPartsBrowserExtension.h,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- KWQKPartsBrowserExtension.h 1 Jun 2005 23:49:49 -0000 1.26
+++ KWQKPartsBrowserExtension.h 4 Dec 2005 00:32:34 -0000 1.27
@@ -91,7 +91,7 @@
bool dialog;
WindowArgs() : x(0), y(0), width(0), height(0),
- menuBarVisible(false), statusBarVisible(true), toolBarsVisible(true), scrollbarsVisible(true),
+ menuBarVisible(true), statusBarVisible(true), toolBarsVisible(true), scrollbarsVisible(true),
resizable(true), fullscreen(false),
xSet(false), ySet(false), widthSet(false), heightSet(false),
dialog(false)
More information about the webkit-changes
mailing list