[webkit-changes] cvs commit: WebCore/khtml/ecma kjs_html.cpp

[Timothy]

thatcher    05/12/02 16:00:51

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               khtml/ecma Tag: Safari-1-3-branch kjs_html.cpp
  Log:
          Merged fix from TOT to Safari-1-3-branch
  
      2005-12-02  Geoffrey Garen  <ggaren at apple.com>
  
          Reviewed by Eric.
  
          Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
          cannot tab to next input field after tab-completing an email address in
          gmail.
  
          Implemented work-around to conceal the selectionEnd property if the
          document is on the gmail domain. We'll remove this code once Google
          fixes its site.
  
          No testcase because this is a domain-specific work-around.
  
          * khtml/ecma/kjs_html.cpp:
          (KJS::HTMLElement::textAreaGetter):
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.335.2.45 +21 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.335.2.44
  retrieving revision 1.335.2.45
  diff -u -r1.335.2.44 -r1.335.2.45
  --- ChangeLog	2 Dec 2005 21:16:00 -0000	1.335.2.44
  +++ ChangeLog	3 Dec 2005 00:00:31 -0000	1.335.2.45
  @@ -2,6 +2,27 @@
   
           Merged fix from TOT to Safari-1-3-branch
   
  +    2005-12-02  Geoffrey Garen  <ggaren at apple.com>
  +
  +        Reviewed by Eric.
  +
  +        Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
  +        cannot tab to next input field after tab-completing an email address in
  +        gmail.
  +
  +        Implemented work-around to conceal the selectionEnd property if the
  +        document is on the gmail domain. We'll remove this code once Google
  +        fixes its site.
  +
  +        No testcase because this is a domain-specific work-around.
  +
  +        * khtml/ecma/kjs_html.cpp:
  +        (KJS::HTMLElement::textAreaGetter):
  +
  +2005-12-02  Timothy Hatcher  <timothy at apple.com>
  +
  +        Merged fix from TOT to Safari-1-3-branch
  +
       2005-12-02  David Hyatt  <hyatt at apple.com>
   
           <rdar://problem/4356387> Glendale Regression: Some text
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.108.4.7 +6 -1      WebCore/khtml/ecma/kjs_html.cpp
  
  Index: kjs_html.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_html.cpp,v
  retrieving revision 1.108.4.6
  retrieving revision 1.108.4.7
  diff -u -r1.108.4.6 -r1.108.4.7
  --- kjs_html.cpp	11 Nov 2005 16:40:23 -0000	1.108.4.6
  +++ kjs_html.cpp	3 Dec 2005 00:00:44 -0000	1.108.4.7
  @@ -1487,7 +1487,12 @@
       case TextAreaReadOnly:        return Boolean(textarea.readOnly());
       case TextAreaRows:            return Number(textarea.rows());
       case TextAreaSelectionStart:  return Number(textarea.selectionStart());
  -    case TextAreaSelectionEnd:    return Number(textarea.selectionEnd());
  +    case TextAreaSelectionEnd:
  +        // FIXME (4363497): Work-around to prevent regression caused by GMail bug (4344954).
  +        // For the love of all that is holy, let's remove this code as soon as Google fixes its bug.
  +        if (impl() && impl()->getDocument() && (impl()->getDocument()->domain() == "mail.google.com"))
  +            return jsUndefined();
  +        return Number(textarea.selectionEnd());
       case TextAreaTabIndex:        return Number(textarea.tabIndex());
       case TextAreaType:            return String(textarea.type());
       case TextAreaValue:           return String(textarea.value());