[webkit-changes] cvs commit: WebCore/khtml/ecma kjs_html.cpp

[Geoffrey]

ggaren      05/12/02 15:19:41

  Modified:    .        ChangeLog
               khtml/ecma kjs_html.cpp
  Log:
          Reviewed by NOBODY (OOPS!).
  
          Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
          cannot tab to next input field after tab-completing an email address in
          gmail.
  
          Implemented work-around to conceal the selectionEnd property if the
          document is on the gmail domain. We'll remove this code once Google
          fixes its site.
  
          No testcase because this is a domain-specific work-around.
  
          * khtml/ecma/kjs_html.cpp:
          (KJS::HTMLElement::textAreaGetter):
  
  Revision  Changes    Path
  1.457     +17 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.456
  retrieving revision 1.457
  diff -u -r1.456 -r1.457
  --- ChangeLog	2 Dec 2005 22:44:25 -0000	1.456
  +++ ChangeLog	2 Dec 2005 23:19:32 -0000	1.457
  @@ -1,3 +1,20 @@
  +2005-12-02  Geoffrey Garen  <ggaren at apple.com>
  +
  +        Reviewed by NOBODY (OOPS!).
  +
  +        Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
  +        cannot tab to next input field after tab-completing an email address in
  +        gmail.
  +
  +        Implemented work-around to conceal the selectionEnd property if the
  +        document is on the gmail domain. We'll remove this code once Google
  +        fixes its site.
  +
  +        No testcase because this is a domain-specific work-around.
  +
  +        * khtml/ecma/kjs_html.cpp:
  +        (KJS::HTMLElement::textAreaGetter):
  +
   2005-12-01  Maciej Stachowiak  <mjs at apple.com>
   
           SVG build fix, not reviewed.
  
  
  
  1.149     +8 -1      WebCore/khtml/ecma/kjs_html.cpp
  
  Index: kjs_html.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_html.cpp,v
  retrieving revision 1.148
  retrieving revision 1.149
  diff -u -r1.148 -r1.149
  --- kjs_html.cpp	2 Dec 2005 03:48:05 -0000	1.148
  +++ kjs_html.cpp	2 Dec 2005 23:19:39 -0000	1.149
  @@ -1682,7 +1682,14 @@
           case TextAreaReadOnly:        return Boolean(textarea.readOnly());
           case TextAreaRows:            return Number(textarea.rows());
           case TextAreaSelectionStart:  return Number(textarea.selectionStart());
  -        case TextAreaSelectionEnd:    return Number(textarea.selectionEnd());
  +        case TextAreaSelectionEnd:
  +            // FIXME (4363497): Work-around to prevent regression caused by GMail bug (4344954).
  +            // For the love of all that is holy, let's remove this code as soon as
  +            // Google fixes its bug.
  +            if (impl() && impl()->getDocument() && (impl()->getDocument()->domain() == "mail.google.com"))
  +                    return jsUndefined();
  +            
  +            return Number(textarea.selectionEnd());
           case TextAreaTabIndex:        return Number(textarea.tabIndex());
           case TextAreaType:            return String(textarea.type());
           case TextAreaValue:           return String(textarea.value());