[webkit-changes] cvs commit: WebCore/khtml/xml dom_nodeimpl.cpp

[Timothy]

thatcher    05/12/01 16:39:00

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml/xml Tag: Safari-2-0-branch dom_nodeimpl.cpp
  Log:
          Merged fix from TOT to Safari-2-0-branch
  
      2005-12-01  Adele Peterson  <adele at apple.com>
  
          Reviewed by Vicki and Dave Harrsion.
  
          - fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding
  
          Fixed a bug in getRect where the code would return a zero sized rect at the
          lower right corner if the origin was 0,0.  This was causing the scrolling code to
          attempt to scroll to the lower left corner of the editable html element in Mail.
  
          Added test:
          * editing/selection/focus_editable_html.html
  
          * khtml/xml/dom_nodeimpl.cpp:
          (DOM::ContainerNodeImpl::getRect):
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.86  +20 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.1.2.85
  retrieving revision 1.1.2.86
  diff -u -r1.1.2.85 -r1.1.2.86
  --- ChangeLog	2 Dec 2005 00:04:24 -0000	1.1.2.85
  +++ ChangeLog	2 Dec 2005 00:38:51 -0000	1.1.2.86
  @@ -1,6 +1,26 @@
   2005-12-01  Timothy Hatcher  <timothy at apple.com>
   
           Merged fix from TOT to Safari-2-0-branch
  +
  +    2005-12-01  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by Vicki and Dave Harrsion.
  +
  +        - fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding
  +
  +        Fixed a bug in getRect where the code would return a zero sized rect at the 
  +        lower right corner if the origin was 0,0.  This was causing the scrolling code to
  +        attempt to scroll to the lower left corner of the editable html element in Mail.
  +
  +        Added test: 
  +        * editing/selection/focus_editable_html.html
  +
  +        * khtml/xml/dom_nodeimpl.cpp:
  +        (DOM::ContainerNodeImpl::getRect):
  +
  +2005-12-01  Timothy Hatcher  <timothy at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
           More fixes NULL checks for button and slider that were not on TOT.
   
       2005-10-28  Beth Dakin  <bdakin at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.140.8.19 +12 -16    WebCore/khtml/xml/dom_nodeimpl.cpp
  
  Index: dom_nodeimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_nodeimpl.cpp,v
  retrieving revision 1.140.8.18
  retrieving revision 1.140.8.19
  diff -u -r1.140.8.18 -r1.140.8.19
  --- dom_nodeimpl.cpp	1 Dec 2005 23:15:47 -0000	1.140.8.18
  +++ dom_nodeimpl.cpp	2 Dec 2005 00:38:59 -0000	1.140.8.19
  @@ -2273,27 +2273,23 @@
   
   QRect NodeBaseImpl::getRect() const
   {
  -    int xPos, yPos;
  -    if (!getUpperLeftCorner(xPos,yPos))
  +    int xPos = 0, yPos = 0, xEnd = 0, yEnd = 0;
  +    bool foundUpperLeft = getUpperLeftCorner(xPos,yPos);
  +    bool foundLowerRight = getLowerRightCorner(xEnd,yEnd);
  +    
  +    // If we've found one corner, but not the other,
  +    // then we should just return a point at the corner that we did find.
  +    if (foundUpperLeft != foundLowerRight)
       {
  -        xPos=0;
  -        yPos=0;
  -    }
  -    int xEnd, yEnd;
  -    if (!getLowerRightCorner(xEnd,yEnd))
  -    {
  -        if (xPos)
  +        if (foundUpperLeft) {
               xEnd = xPos;
  -        if (yPos)
               yEnd = yPos;
  -    }
  -    else
  -    {
  -        if (xPos==0)
  +        } else {
               xPos = xEnd;
  -        if (yPos==0)
               yPos = yEnd;
  -    }
  +        }
  +    } 
  +
       if (xEnd < xPos)
           xEnd = xPos;
       if (yEnd < yPos)