[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp html_formimpl.h

[Timothy]

thatcher    05/12/01 10:34:39

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               khtml/html Tag: Safari-1-3-branch html_formimpl.cpp
                        html_formimpl.h
  Log:
          Merged fix from TOT to Safari-1-3-branch
          Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
          gmail 'reply' does not fill in to: field or quoted message (3751)
  
      2005-07-09  Anders Carlsson  <andersca at mac.com>
  
          - Fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=3751>
  
          Reviewed by Maciej.
  
          * khtml/html/html_formimpl.cpp:
          (DOM::HTMLTextAreaElementImpl::attach):
          * khtml/html/html_formimpl.h:
          Update the value after attaching so we'll be sure that
          the text renderer has a valid value.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.335.2.39 +18 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.335.2.38
  retrieving revision 1.335.2.39
  diff -u -r1.335.2.38 -r1.335.2.39
  --- ChangeLog	30 Nov 2005 22:46:04 -0000	1.335.2.38
  +++ ChangeLog	1 Dec 2005 18:34:26 -0000	1.335.2.39
  @@ -1,3 +1,21 @@
  +2005-12-01  Timothy Hatcher  <timothy at apple.com>
  +
  +        Merged fix from TOT to Safari-1-3-branch
  +        Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
  +        gmail 'reply' does not fill in to: field or quoted message (3751)
  +
  +    2005-07-09  Anders Carlsson  <andersca at mac.com>
  +
  +        - Fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=3751>
  +
  +        Reviewed by Maciej.
  +
  +        * khtml/html/html_formimpl.cpp:
  +        (DOM::HTMLTextAreaElementImpl::attach):
  +        * khtml/html/html_formimpl.h:
  +        Update the value after attaching so we'll be sure that
  +        the text renderer has a valid value.
  +
   2005-11-29  Timothy Hatcher  <timothy at apple.com>
   
           Fix by Beth and Darin
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.156.4.7 +13 -6     WebCore/khtml/html/html_formimpl.cpp
  
  Index: html_formimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
  retrieving revision 1.156.4.6
  retrieving revision 1.156.4.7
  diff -u -r1.156.4.6 -r1.156.4.7
  --- html_formimpl.cpp	18 Nov 2005 18:01:24 -0000	1.156.4.6
  +++ html_formimpl.cpp	1 Dec 2005 18:34:33 -0000	1.156.4.7
  @@ -3291,13 +3291,13 @@
       for (n = firstChild(); n; n = n->nextSibling())
           if (n->isTextNode())
               val += static_cast<TextImpl*>(n)->data();
  +    
       if (val[0] == '\r' && val[1] == '\n') {
  -	val = val.copy();
  -	val.remove(0,2);
  -    }
  -    else if (val[0] == '\r' || val[0] == '\n') {
  -	val = val.copy();
  -	val.remove(0,1);
  +        val = val.copy();
  +        val.remove(0,2);
  +    } else if (val[0] == '\r' || val[0] == '\n') {
  +        val = val.copy();
  +        val.remove(0,1);
       }
   
       return val;
  @@ -3341,6 +3341,13 @@
       focus();
   }
   
  +void HTMLTextAreaElementImpl::attach()
  +{
  +    m_valueIsValid = true;
  +    HTMLGenericFormElementImpl::attach();
  +    updateValue();
  +}
  +
   void HTMLTextAreaElementImpl::detach()
   {
       HTMLGenericFormElementImpl::detach();
  
  
  
  1.67.4.4  +1 -0      WebCore/khtml/html/html_formimpl.h
  
  Index: html_formimpl.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.h,v
  retrieving revision 1.67.4.3
  retrieving revision 1.67.4.4
  diff -u -r1.67.4.3 -r1.67.4.4
  --- html_formimpl.h	11 Nov 2005 16:40:28 -0000	1.67.4.3
  +++ html_formimpl.h	1 Dec 2005 18:34:35 -0000	1.67.4.4
  @@ -652,6 +652,7 @@
       virtual void childrenChanged();
       virtual void parseHTMLAttribute(HTMLAttributeImpl *attr);
       virtual khtml::RenderObject *createRenderer(RenderArena *, khtml::RenderStyle *);
  +    virtual void attach();
       virtual void detach();
       virtual bool appendFormData(FormDataList&, bool);
       virtual void reset();