[webkit-changes] cvs commit: JavaScriptCore/kjs config.h function.cpp operations.cpp

[Darin]

darin       05/08/31 00:57:56

  Modified:    .        ChangeLog
               kjs      config.h function.cpp operations.cpp
  Log:
          Reviewed, tweaked, and landed by Darin.
  
          - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4085
          - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4087
          - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4096
            Some fixes for compiling on windows.
  
          * kjs/config.h: Added a WIN32 case in here, with suitable defines.
          (To be tweaked as necessary.)
          * kjs/function.cpp: Took out APPLE_CHANGES around use of ICU.
          * kjs/operations.cpp: Removed some bogus code that always set HAVE_FLOAT_H.
  
  Revision  Changes    Path
  1.811     +14 -0     JavaScriptCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
  retrieving revision 1.810
  retrieving revision 1.811
  diff -u -r1.810 -r1.811
  --- ChangeLog	30 Aug 2005 23:56:13 -0000	1.810
  +++ ChangeLog	31 Aug 2005 07:57:55 -0000	1.811
  @@ -1,3 +1,17 @@
  +2005-08-31  Justin Haygood  <justin at xiondigital.net>
  +
  +        Reviewed, tweaked, and landed by Darin.
  +
  +        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4085
  +        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4087
  +        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4096
  +          Some fixes for compiling on windows.
  +
  +        * kjs/config.h: Added a WIN32 case in here, with suitable defines.
  +        (To be tweaked as necessary.)
  +        * kjs/function.cpp: Took out APPLE_CHANGES around use of ICU.
  +        * kjs/operations.cpp: Removed some bogus code that always set HAVE_FLOAT_H.
  +
   2005-08-30  Darin Adler  <darin at apple.com>
   
           Reviewed by John Sullivan.
  
  
  
  1.7       +15 -3     JavaScriptCore/kjs/config.h
  
  Index: config.h
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/kjs/config.h,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- config.h	22 Sep 2003 15:21:10 -0000	1.6
  +++ config.h	31 Aug 2005 07:57:56 -0000	1.7
  @@ -1,12 +1,24 @@
  +#if !WIN32
  +
   #define HAVE_FUNC_ISINF 1
   #define HAVE_FUNC_ISNAN 1
  -#define HAVE_FUNC_STRTOLL 1
  -#define HAVE_STRING_H 1
   #define HAVE_STRINGS_H 1
   #define HAVE_SYS_PARAM_H 1
   #define HAVE_SYS_TIME_H 1
  -#define HAVE_PCREPOSIX 1
   #define TIME_WITH_SYS_TIME 1
  +
  +#else
  +
  +#define HAVE_FLOAT_H 1
  +#define HAVE_FUNC__FINITE 1
  +
  +#endif
  +
  +#define HAVE_FUNC_STRTOLL 1
  +#define HAVE_ICU 1
  +#define HAVE_PCREPOSIX 1
  +#define HAVE_STRING_H 1
  +
   #ifdef __ppc__
   #define WORDS_BIGENDIAN 1
   #endif
  
  
  
  1.56      +1 -7      JavaScriptCore/kjs/function.cpp
  
  Index: function.cpp
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/kjs/function.cpp,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- function.cpp	30 Aug 2005 23:56:13 -0000	1.55
  +++ function.cpp	31 Aug 2005 07:57:56 -0000	1.56
  @@ -38,10 +38,9 @@
   #include <stdlib.h>
   #include <assert.h>
   #include <string.h>
  +#include <ctype.h>
   
  -#if APPLE_CHANGES
   #include <unicode/uchar.h>
  -#endif
   
   using namespace KXMLCore;
   
  @@ -660,12 +659,7 @@
           case 0x2029:
               return true;
           default:
  -#if APPLE_CHANGES
               return u_charType(c) == U_SPACE_SEPARATOR;
  -#else
  -            // ### properly support other Unicode Zs characters
  -            return false;
  -#endif
       }
   }
   
  
  
  
  1.9       +0 -4      JavaScriptCore/kjs/operations.cpp
  
  Index: operations.cpp
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/kjs/operations.cpp,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- operations.cpp	8 Aug 2005 04:07:29 -0000	1.8
  +++ operations.cpp	31 Aug 2005 07:57:56 -0000	1.9
  @@ -23,10 +23,6 @@
   #ifdef HAVE_CONFIG_H
   #include "config.h"
   #endif
  -#ifndef HAVE_FLOAT_H   /* just for !Windows */
  -#define HAVE_FLOAT_H 0
  -#define HAVE_FUNC__FINITE 0
  -#endif
   
   #include <stdio.h>
   #include <assert.h>